Skip to content

Add test to check shortcut functionality#119

Merged
matiaswilner merged 5 commits intomasterfrom
test_history
Sep 10, 2021
Merged

Add test to check shortcut functionality#119
matiaswilner merged 5 commits intomasterfrom
test_history

Conversation

@matiaswilner
Copy link
Copy Markdown
Contributor

No description provided.

@sourcelevel-bot
Copy link
Copy Markdown

Hello, @matiaswilner! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@matiaswilner matiaswilner requested a review from eldano September 9, 2021 16:54
Copy link
Copy Markdown
Contributor

@eldano eldano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first PR!
I left a couple of comments, feel free to discuss them before making changes

Comment thread test/elixir_console_web/features/console_test.exs
Comment thread test/elixir_console_web/features/console_test.exs Outdated
Comment thread test/elixir_console_web/features/console_test.exs Outdated
Copy link
Copy Markdown
Contributor

@eldano eldano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the changes

@matiaswilner matiaswilner merged commit c421548 into master Sep 10, 2021
@matiaswilner matiaswilner deleted the test_history branch September 10, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants