Skip to content

fix: address memo review findings and simplify memo flow#4

Merged
wynxing merged 1 commit into
mainfrom
fork-pr-228-1775900312
Apr 11, 2026
Merged

fix: address memo review findings and simplify memo flow#4
wynxing merged 1 commit into
mainfrom
fork-pr-228-1775900312

Conversation

@fennoai

@fennoai fennoai Bot commented Apr 11, 2026

Copy link
Copy Markdown

Requested by @Yumiue

Summary

  • preserve explicit false for memo config flags and keep YAML semantics stable
  • wire memo context cache invalidation callback in bootstrap
  • make memo index/topic persistence order consistency-safe and add regression tests
  • normalize memo title handling and inject memo index as a data block in prompt
  • apply small simplifications from code-simplifier review

- preserve explicit false for memo config flags
- wire memo cache invalidation callback in bootstrap
- make memo service index/topic updates consistency-safe
- sanitize memo titles and inject memo index as data block
- add regression tests and simplification cleanups

Generated with [codeagent](https://github.com/qbox/codeagent)
Co-authored-by: Yumiue <188874804+Yumiue@users.noreply.github.com>
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 85.00000% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/memo/service.go 84.21% 4 Missing and 2 partials ⚠️
internal/tui/core/app/update.go 0.00% 5 Missing ⚠️
internal/memo/context_source.go 88.88% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@wynxing wynxing merged commit 6d577d1 into main Apr 11, 2026
1 check passed
@fennoai fennoai Bot deleted the fork-pr-228-1775900312 branch April 11, 2026 10:55
fennoai Bot pushed a commit that referenced this pull request Apr 13, 2026
fix(runtime): recycle session locks and harden nil maps
wynxing pushed a commit that referenced this pull request Apr 21, 2026
test: raise patch coverage for gateway runtime migration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants