Skip to content

fix(memo): address review findings in PR #245#6

Merged
wynxing merged 1 commit into
mainfrom
fork-pr-245-1776040827
Apr 13, 2026
Merged

fix(memo): address review findings in PR #245#6
wynxing merged 1 commit into
mainfrom
fork-pr-245-1776040827

Conversation

@fennoai

@fennoai fennoai Bot commented Apr 13, 2026

Copy link
Copy Markdown

Requested by @Yumiue

Summary

  • Fix unresolved review findings for memo extractor/runtime/tools
  • Add nil service guards and output limit for memo tools
  • Add regression tests for UTF-8 truncation and runtime memo extraction input

…egration

- use rune-safe title truncation for auto extracted memo entries
- guard memo remember/recall tools against nil service and cap recall output
- limit runtime memo extraction input and add bounded async execution
- add regression tests for utf-8 truncation, nil guards, output limit, and runtime hook

Generated with [codeagent](https://github.com/qbox/codeagent)
Co-authored-by: Yumiue <188874804+Yumiue@users.noreply.github.com>
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 74.62687% with 17 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/runtime/runtime.go 64.86% 8 Missing and 5 partials ⚠️
internal/memo/extractor.go 78.94% 2 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@wynxing wynxing merged commit 38dce8f into main Apr 13, 2026
1 check passed
@fennoai fennoai Bot deleted the fork-pr-245-1776040827 branch April 13, 2026 07:33
wynxing pushed a commit that referenced this pull request Apr 14, 2026
test(app): close unresolved review follow-ups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants