Skip to content

[codex] Restore live disable draft preview#223

Merged
xTracr merged 5 commits into
xTracr:26.1/devfrom
rsdadada:codex/disable-live-preview-fix
Jul 4, 2026
Merged

[codex] Restore live disable draft preview#223
xTracr merged 5 commits into
xTracr:26.1/devfrom
rsdadada:codex/disable-live-preview-fix

Conversation

@rsdadada

@rsdadada rsdadada commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Restore live preview updates while editing an existing hidden disable setting by overlaying the current same-name draft when generating a BindTarget.
  • Keep new or renamed disable drafts explicit: drafts without an existing name match are not added until the right-side + action or DISABLE-page save synchronizes them.
  • Include the current same-name draft in generated targets used by rendering, save, and export.
  • Reload the generated target after saving from CONFIGS or PREVIEW so the editor's disable-config list stays synchronized; DISABLE-page saves keep the active draft intact.

Root cause

PR #213 removed the same-name draft replacement from genBindTarget(). That simplified save generation, but also removed the per-frame draft overlay that made edits to an existing hidden disable setting immediately visible.

This PR restores that replacement on a copied disable-config list. The staged source list is not mutated during rendering, and unmatched drafts are not implicitly added.

Validation

  • Temporary JUnit regression tests passed before being removed as requested: same-name replacement, source-list isolation, and unmatched drafts not being added.
  • .\gradlew.bat :common:test
  • .\gradlew.bat build
  • git diff --check
  • GitHub Actions build

@rsdadada
rsdadada marked this pull request as ready for review July 2, 2026 17:33
@xTracr
xTracr self-requested a review July 3, 2026 05:25
Comment thread common/src/main/java/com/xtracr/realcamera/gui/ModelViewScreen.java Outdated
rsdadada and others added 4 commits July 3, 2026 19:07
Co-authored-by: xTracr <57320980+xTracr@users.noreply.github.com>
Signed-off-by: rsdadada <rsddadada@outlook.com>
@xTracr
xTracr merged commit a0e473e into xTracr:26.1/dev Jul 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants