[codex] Restore live disable draft preview#223
Merged
Conversation
rsdadada
marked this pull request as ready for review
July 2, 2026 17:33
This was referenced Jul 2, 2026
xTracr
self-requested a review
July 3, 2026 05:25
xTracr
reviewed
Jul 3, 2026
Co-authored-by: xTracr <57320980+xTracr@users.noreply.github.com> Signed-off-by: rsdadada <rsddadada@outlook.com>
xTracr
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BindTarget.+action or DISABLE-page save synchronizes them.Root cause
PR #213 removed the same-name draft replacement from
genBindTarget(). That simplified save generation, but also removed the per-frame draft overlay that made edits to an existing hidden disable setting immediately visible.This PR restores that replacement on a copied disable-config list. The staged source list is not mutated during rendering, and unmatched drafts are not implicitly added.
Validation
.\gradlew.bat :common:test.\gradlew.bat buildgit diff --checkbuild