Skip to content

Stop Thunder from deleting quotes on QuotedTweetDeleteEvent - #138

Open
Pitchfork-and-Torch wants to merge 1 commit into
xai-org:mainfrom
Pitchfork-and-Torch:cursor/thunder-quoted-delete-wrong-id-63f9
Open

Stop Thunder from deleting quotes on QuotedTweetDeleteEvent#138
Pitchfork-and-Torch wants to merge 1 commit into
xai-org:mainfrom
Pitchfork-and-Torch:cursor/thunder-quoted-delete-wrong-id-63f9

Conversation

@Pitchfork-and-Torch

Copy link
Copy Markdown

Bug

QuotedTweetDeleteEvent is a quote-card update. The quoting post still exists. Thunder treated quoting_tweet_id as a TweetDelete and removed the quote from the in-network store.

TweetDeleteEvent already removes the tweet that was actually deleted (the original, or a quote the author deleted).

Proof

  • Entry: thunder/kafka/tweet_events_listener.rs (feeder InNetworkEvent deletes)
  • Sink: PostStore.mark_as_deleted -> GetInNetworkPosts
  • Break: QuotedTweetDeleteEvent used quoting_tweet_id as a delete
  • Viewer effect: a followee quote vanished from Following / For You in-network when the quoted original was deleted
  • Twin: TweetDeleteEvent already deletes the real tweet; QuotedTweetTakedownEvent was already ignored

Fix

Ignore QuotedTweetDeleteEvent for in-network deletes. Keep TweetDeleteEvent retention as-is.

Tests

Standalone decision table (same predicate): 4/4 passed.

  • TweetDelete within retention still deletes that tweet
  • TweetDelete past retention stays ignored
  • QuotedTweetDelete does not delete the quoting post
  • QuotedTweetTakedown still does not delete

cargo test cannot run. Public dump has no Thunder Cargo.toml.

Notes

Not TES id wipe (#94). Not QuoteHydrator (#117/#118). Not VF quote scoring (#115/#119).

QuotedTweetDeleteEvent is a quote-card update. The quoting post still exists.
TweetDeleteEvent already removes the tweet that was actually deleted.
@Pitchfork-and-Torch
Pitchfork-and-Torch force-pushed the cursor/thunder-quoted-delete-wrong-id-63f9 branch from 0434fc8 to 902a06f Compare September 7, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant