Stop Thunder from deleting quotes on QuotedTweetDeleteEvent - #138
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Stop Thunder from deleting quotes on QuotedTweetDeleteEvent#138Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
This was referenced Sep 7, 2026
QuotedTweetDeleteEvent is a quote-card update. The quoting post still exists. TweetDeleteEvent already removes the tweet that was actually deleted.
Pitchfork-and-Torch
force-pushed
the
cursor/thunder-quoted-delete-wrong-id-63f9
branch
from
September 7, 2026 16:26
0434fc8 to
902a06f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
QuotedTweetDeleteEvent is a quote-card update. The quoting post still exists. Thunder treated quoting_tweet_id as a TweetDelete and removed the quote from the in-network store.
TweetDeleteEvent already removes the tweet that was actually deleted (the original, or a quote the author deleted).
Proof
Fix
Ignore QuotedTweetDeleteEvent for in-network deletes. Keep TweetDeleteEvent retention as-is.
Tests
Standalone decision table (same predicate): 4/4 passed.
cargo testcannot run. Public dump has no Thunder Cargo.toml.Notes
Not TES id wipe (#94). Not QuoteHydrator (#117/#118). Not VF quote scoring (#115/#119).