Skip to content

Fix mute/block asymmetry: drop quotes of muted authors - #23

Open
Pitchfork-and-Torch wants to merge 1 commit into
xai-org:mainfrom
Pitchfork-and-Torch:fix/mute-quoted-author
Open

Fix mute/block asymmetry: drop quotes of muted authors#23
Pitchfork-and-Torch wants to merge 1 commit into
xai-org:mainfrom
Pitchfork-and-Torch:fix/mute-quoted-author

Conversation

@Pitchfork-and-Torch

Copy link
Copy Markdown

Summary

AuthorSocialgraphFilter already drops a candidate when the viewer blocks the quoted author (quoted_user_id vs blocked_user_ids). Mute only checked candidate.author_id, so a quote of a muted user still served.

This PR clones the block twin for mute. One class, one file. No ranking changes. Retweet mute stays in PR 9.

Proof

  • Entry: muted_user_ids_query_hydrator.rs writes query.user_features.muted_user_ids
  • Sink: AuthorSocialgraphFilter
  • Break: mute matched author_id only; quoted_user_id was block-only
  • Viewer effect: F quotes muted user Q; viewer still sees the quote
  • Twin: viewer_blocks_quoted_author

Test plan

  • test_muted_quoted_author_is_removed fails on main, passes on this branch
  • test_unmuted_quoted_author_is_kept still keeps a quote of an unmuted user
  • unit tests added; cargo test cannot run in the public dump

AuthorSocialgraphFilter already drops quotes of blocked authors via
quoted_user_id. Mute only checked candidate.author_id, so a quote of a
muted user still served. Clone the block twin for mute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant