fix: stop SMGC service on SR detach to prevent orphaned systemd units - #770
Merged
MarkSymsCtx merged 1 commit intoSep 22, 2025
Merged
Conversation
MarkSymsCtx
requested changes
Aug 21, 2025
| # However, we should still delete lock files on slaves as it is the | ||
| # only place to do so. | ||
| self._cleanup(self.isMaster) | ||
| cleanup.stop_gc_service(sr_uuid) |
Contributor
There was a problem hiding this comment.
This should replace the cleanup.abort() at line 589, or alternatively make cleanup.abort() stop the service.
Contributor
Author
There was a problem hiding this comment.
Ok, made it so cleanup.stop_gc_service is called in cleanup.abort
Millefeuille42
force-pushed
the
upstream-cleanup-SMGC-units
branch
2 times, most recently
from
August 21, 2025 14:54
2387e7c to
9f07b80
Compare
Signed-off-by: Mathieu Labourier <mathieu.labourier@vates.tech>
Millefeuille42
force-pushed
the
upstream-cleanup-SMGC-units
branch
from
August 21, 2025 15:34
9f07b80 to
30ea702
Compare
MarkSymsCtx
approved these changes
Aug 27, 2025
TimSmithCtx
approved these changes
Aug 27, 2025
Contributor
|
There were two approvals last month. Are we getting close to a merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not done on every and each implementation of SR but only on ones that calls
cleanup.start_gc_service(likeFileSR) and on the classes that inherits from them and don't call super ondetach.This is to prevent useless errors logs like
Failed to stop xxx.service: Unit xxx.service not loaded.