CA-426637: Drain the remaining bytes in metadata_handler - #7209
Open
changlei-li wants to merge 1 commit into
Open
CA-426637: Drain the remaining bytes in metadata_handler#7209changlei-li wants to merge 1 commit into
changlei-li wants to merge 1 commit into
Conversation
When make_tar ova.xml, the tar file length is topically ``` tar header (512) + xml + zero_pad to 512 + end-of-archive marker (2 × 512) + padding to RECORDSIZE ``` In metadata_handler, the with_open_archive reads to zero_pad, then it skipps end-of-archive marker. The remaining padding is not consumed. In some corner case, the server (XAPI) might close the connection when the client was still sending the padding part. Then the client would get a EPIPE error. In this PR, content-length is used to drain the remaining bytes in metadata_handler. Signed-off-by: Changlei Li <changlei.li@citrix.com>
last-genius
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When make_tar ova.xml, the tar file length is topically
In metadata_handler, the with_open_archive reads to zero_pad, then it skipps end-of-archive marker. The remaining padding is not consumed.
In some corner case, the server (XAPI) might close the connection when the client was still sending the padding part. Then the client would get a EPIPE error.
In this PR, content-length is used to drain the remaining bytes in metadata_handler.