Skip to content

Conversation

@dcherian
Copy link
Contributor

Could use some input here.

  1. I like the idea of having apply_ufunc and map_blocks as dropdowns. Optimistically, we'll have 4-5 notebooks here, and the material is advanced enough that it's nice to break it up.

  2. But we need some high-level intro as shown in the screenshot. Right now it looks funny on its own in the left sidebar. We cannot make it a top-level heading with apply_ufunc and map_blocks as subheadings because then we'd lose the ability to do 1.

image

Any ideas on how to resolve this? Alternatively maybe this type of intro should move to the narrative docs (docs.xarray.dev)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dcherian dcherian marked this pull request as draft June 28, 2022 02:33
@dcherian
Copy link
Contributor Author

dcherian commented Jun 28, 2022

The other solution would be to duplicate this intro material in both apply_ufunc/apply_ufunc.md and map_blocks/map_blocks.md . Both these files just have tableofcontents for now.

My concern here is that it is not obvious that intro material is present at the top-level heading. Would you click apply_ufunc or just the drop-down arrow?

So we could also add it as "introduction" under "apply_ufunc" and "map_blocks"

@dcherian dcherian force-pushed the apply-ufunc-map-blocks branch from 4e6c9e8 to e4ec964 Compare June 28, 2022 22:02
@dcherian dcherian marked this pull request as ready for review July 1, 2022 17:56
@dcherian dcherian merged commit 5cf8a76 into main Jul 1, 2022
@dcherian dcherian deleted the apply-ufunc-map-blocks branch July 1, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants