Advanced Indexing - Update Exercise solution #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The small exercise at the bottom of the page declared two DataArrays, but only used one. The solution was still correct but confusing, so I reduced the needed variable declaration to the required one and renamed.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ianhi
reviewed
Nov 26, 2025
Contributor
ianhi
left a comment
ianhi
left a comment
There was a problem hiding this comment.
Thanks @jomey I agree that that is a little bit confusing. Though I'm not sure this is the best solution because it's a little confusing to have the same argument for both x and y and doesn't fully showcase the power.
I left a proposed change. curious what you think of that approach instead?
|
🎊 PR Preview b38cf8f has been successfully built and deployed to https://xarray-contrib-xarray-tutorial-preview-pr-348.surge.sh 🕐 Build time: 0.011s
🤖 By surge-preview |
Vary the showcase x and y coords as suggested by @ianhi
Contributor
|
Thanks for the contribution @jomey ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The small exercise at the bottom of the page declared two DataArrays, but only used one. The solution was still correct but confusing, so I reduced the needed variable declaration to the required one and renamed.