Skip to content

Conversation

@scottyhq
Copy link
Contributor

@scottyhq scottyhq commented Jun 22, 2022

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dcherian
Copy link
Contributor

Works after I fixed the link. Nice!

I did find a typo, somehow the codespell action didn't catch it

indermediate/

It'd be nice to automate that index.ipynb. It seems like a sphinx toctree thing. So we could potentially have index.md with a sphinx toctree directive and present that: https://myst-nb.readthedocs.io/en/latest/authoring/text-notebooks.html#myst-notebooks-in-jupyter-interfaces

@scottyhq
Copy link
Contributor Author

I did find a typo, somehow the codespell action didn't catch it

Yeah, codespell definitely does not catch all typos!

It'd be nice to automate that index.ipynb

Definitely agree, I'll have a look at how to do that.

index.md with a sphinx toctree directive

myst-markdown definitely seems nice, but i'm so used to ipynb! Looks like the numpy tutorial exclusively uses myst-nb https://numpy.org/numpy-tutorials/contributing.html#adding-your-own-tutorials

@scottyhq scottyhq marked this pull request as draft June 22, 2022 18:59
@dcherian
Copy link
Contributor

dcherian commented Jul 7, 2022

I wonder if this should instead be the workshops/scipy-2022/README.md file rendered as a notebook.

@scottyhq scottyhq marked this pull request as ready for review July 8, 2022 00:16
@scottyhq
Copy link
Contributor Author

scottyhq commented Jul 8, 2022

going to go ahead and merge this as a temporary fix. Could be nice to autogenerate a complete notebook index in the future!

@scottyhq scottyhq merged commit 0b899f2 into xarray-contrib:main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Customize binder startup to show notebook index

2 participants