fix: Fixes the search bar appearance in production - #2
Merged
Goldziher merged 1 commit intoAug 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the search bar appearance in production and brings the rest of the
search modal in line with the brand design.
The bug: a large X rendered across the middle of the search bar, and text
typed into it was invisible. Search itself worked — results came back
correctly — the input just looked empty.
The cause: the header's button styling was also landing on the search
modal's internals, stretching the clear button across the full width of the
input and covering it.
Also: focus states in the search modal were falling back to the browser
default, which follows the OS accent colour and shows up orange on most
machines. The input, the clear button, and the results now all use the brand
green, in both light and dark. Light mode uses the deeper green so the ring
stays legible against white.
Only visible in a production build — the search UI isn't generated in dev.