Conversation
|
Can one of the admins verify this patch? |
| - image: xcomponent/mono-git:1.3.0 | ||
| steps: | ||
| - checkout | ||
| - run: ./build.sh -t All |
| @@ -0,0 +1,14 @@ | |||
| version: 2 | |||
| jobs: | |||
| checkout_code: | |||
There was a problem hiding this comment.
rename this job, it does more than checking out code
maurelio1234
left a comment
maurelio1234
left a comment
There was a problem hiding this comment.
Improve naming in config.yml
|
@anouarhassine what do you think about this PR? |
|
Why is not a circle ci build being triggered yet? |
|
Okay. @fle-bach , Now that the Circle Ci trigger is fixed, could you please make the changes mentioned by @maurelio1234 ? Because your config now starts a workflow called xcomponent_runtime and it has one job called checkout_code. the workflow should be called something like xcomponent_reactive_api and you can rename the job to better describe what it does or to split it into multiple little jobs. |
anouarhassine
left a comment
anouarhassine
left a comment
There was a problem hiding this comment.
Update the badges section in Readme file to add a badge from Circle Ci.
|
Replaced by #91 |
4 participants
No description provided.