Test Intergration with a console app who use an ApiReactive#91
Merged
nicolaserny merged 53 commits intoxcomponent:masterfrom Feb 14, 2019
fle-bach:master
Merged
Test Intergration with a console app who use an ApiReactive#91nicolaserny merged 53 commits intoxcomponent:masterfrom fle-bach:master
nicolaserny merged 53 commits intoxcomponent:masterfrom
fle-bach:master
Conversation
Contributor
fle-bach
commented
Feb 13, 2019
fle-bach
commented
- circleci migration
… task clean tmp files
nicolaserny
requested changes
Feb 13, 2019
…d - badge xcomponent
… into TIReactiveApi
nicolaserny
requested changes
Feb 14, 2019
nicolaserny
left a comment
nicolaserny
left a comment
There was a problem hiding this comment.
Remove tools and lib folder + update gitignore
nicolaserny
requested changes
Feb 14, 2019
nicolaserny
approved these changes
Feb 14, 2019
maurelio1234
approved these changes
Feb 14, 2019
Member
|
In general looks fine for me, added a couple of comments, but they are optional. Do not forget to squash the PR instead of simply merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.