Revert e2e test and run spec on Github Actions #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 18c402c. fix xcpretty#383
rubocop --auto-correct
Contributor
Author
Collaborator
|
Looks reasonable, we can investigate why those other tests failed at some point later |
Collaborator
|
Thanks for keeping tabs on this! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #383
Currently, the E2E test is not working properly and always failing.
So I'd like to stop using it and instead run the specs that previously run on CircleCI. It will help us to develop xcode-install.
I don't know thy test has not been running in CircleCI recently, but GitHub Actions can be used as an alternative.
I tried to run ci.yml on my forked repository (Kesin11#6) and found some issues.
"fetch" test failed randomly on CI. It works on my machine, but not on GitHub Actions. I commented out it to stabilize the behavior of CI.
And rubcop shows some violations. I just fix it with
rubocop --auto-correct