Inconsistent casing#244
Closed
johnrom wants to merge 43 commits intoxdebug:inconsistent-casingfrom
Closed
Conversation
Adds support for mapping multiple server source roots to local roots. Closes xdebug#54
after_success swallows errors
In response to the issue I had here a while back microsoft/vscode#23518 I feel this will ease the contribution barrier a little bit. Even though error reporting for said issue has already been taken care of.
# Conflicts: # src/paths.ts # src/test/paths.ts
Contributor
|
Could you rebase this to include only your change? |
Contributor
Author
|
I'm just going to build a new PR from |
Contributor
Author
|
closed in favor of #245 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Merge master into this branch in order to see the real changes! I accidentally did them both at once
This should be a complete fix for the case-sensitivity issue, though it's not the prettiest. It seems to me that either VS Code or some other dependency in my team's environment also started using lowercase drive names when reporting the file path, even though the
pathMappingspecifies an uppercase one. Breakpoints aren't working on any of my sites anymore with the current release of this extension/VSCode, which makes it borderline unusable.I hope this is helpful.