Merged
Conversation
PapyChacal
approved these changes
Nov 28, 2023
Collaborator
PapyChacal
left a comment
PapyChacal
left a comment
There was a problem hiding this comment.
Looks good to me !
Not familiar with the tricky bits, but I guess we have CI to trust now 🙂
georgebisbas
force-pushed
the
compiler_more
branch
from
b8eccf8 to
7552504
Compare
georgebisbas
commented
Nov 28, 2023
Collaborator
Author
georgebisbas
left a comment
georgebisbas
left a comment
There was a problem hiding this comment.
@PapyChacal I added some more commits; please have another look.
PapyChacal
approved these changes
Nov 28, 2023
Collaborator
PapyChacal
left a comment
PapyChacal
left a comment
There was a problem hiding this comment.
Idem!
Really nice to see this cleaned up 😊
PapyChacal
approved these changes
Dec 5, 2023
Collaborator
PapyChacal
left a comment
PapyChacal
left a comment
There was a problem hiding this comment.
Another approval after last commits!
georgebisbas
force-pushed
the
compiler_more
branch
from
044a847 to
97faa07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.