Merged
Conversation
Use "json" which is a part of Ruby stdlib since 1.9.0. Closes #1632
Removed unnecessary test_module.js and test_module_dep.js. Fixed compile errors. Signed-off-by: Jason Leyba <jmleyba@gmail.com>
…is or jleyba for the client_secrets.json
Fixes #1679 Added logic to remove the ShutdownHook that TemporaryFileSystem was injecting for cleaning up temporary files created by Selenium, after the cleanup was completed. Signed-off-by: Luke Inman-Semerau <luke.semerau@gmail.com>
…nd / override. needed to be able to set a grid to use a http proxy without setting the entire jvm with a proxy
f91121d This test was trivially passing before because errors were always being caught. The closure update included changes to the testing framework that detected these types of bugs and reported them as failures. I'm not sure what the test was actually trying to exercise, so I've changed it to what I *think* it was going for.
Fixes #1730
2) Explicitly ignoring HTML5 tests in HtmlUnit because it defines itself as FF38 now.
1. Add UnsupportedOperationError when trying to deselect options of non-multiseect 2. Update select_by_index, deselect_by_index to only deselect first option, since index is unique. 3. Add tests to select_spec
Signed-off-by: Titus Fortner <titusfortner@gmail.com>
Signed-off-by: Titus Fortner <titusfortner@gmail.com>
Paired with trabulmonkee on this Signed-off-by: Titus Fortner <titusfortner@gmail.com>
Signed-off-by: Luke Inman-Semerau <luke.semerau@gmail.com>
…art it, which calls initServer). Getting rid of lots of magic strings related to tests creating a new session / grid console page. Deleting old servlets from the hub.
…accepts a generic argument and doesn't return a value. Signed-off-by: Jim Evans <james.h.evans.jr@gmail.com>
Signed-off-by: Jim Evans <james.h.evans.jr@gmail.com>
Signed-off-by: Jim Evans <james.h.evans.jr@gmail.com>
…on a property that no longer exists. Fixes #1827
…lue is not a string. This would have caught the bad test from #1827
TODO: we need some tests of the SeleniumServer class
As suggested by the Closure library team, goog.array.ArrayLike is obsolete, IArrayLike should replace it to encourage better typechecking. See also https://docs.google.com/document/d/1eNpI_02NYb8K-x014Jo8iO6wjlpQQttDO3mVYZUXVtQ Fixes #1771 Signed-off-by: Jason Leyba <jmleyba@gmail.com>
We had some tests observe incomplete copies pretty frequently, and this seems to fix it. If for some reason this turns out to be noticeably less efficient than FileChannel, we can rewrite it back to FileChannel and loop to make sure it copies everything. (Committed on behalf of a Googler.)
…since those aren't working
keys_to_typing handles list of Keys. keys_to_typing behavior was regressed by an implementation change. This change reverts keys_to_typing to its former behavior. That is, element.send_keys([Keys.ENTER]) should result in the ENTER key being pressed, not the unicode representation of ENTER defined in common/keys.py to be typed into a text field. Fixes #1839 Signed-off-by: Luke Inman-Semerau <luke.semerau@gmail.com>
Where safe, replace Throwables.propagate with equivalent behavior: either "throw e" or "throw new RuntimeException(e)". This is in preparation for Guava owners to delete this method. Note that not all instances of Throwables.propagate have been removed: those which could possibly result in the change of type of the resulting exception. Signed-off-by: Luke Inman-Semerau <luke.semerau@gmail.com>
… phantomjs/htmlunit to buck standalone-server build Fixes #1847
Signed-off-by: Luke Inman-Semerau <luke.semerau@gmail.com>
…tate Prior to this commit, the driver would only respect the page load strategy for document.readyState, not for the browser COM object. This means that, for example, when IE has an info bar being displayed (like when downloading a file), the driver will wait indefinitely, since the IWebBrowser2 object's ReadyState property will never cycle over to "complete," topping out at "interactive." Fixes issue #999. Fixes issue #1843.
Fixes #1854 Signed-off-by: Luke Inman-Semerau <luke.semerau@gmail.com>
Use simple Request class name rather than the fully-specified class name (that is, including the package name) as it is already imported. Signed-off-by: Daniel Davison <daniel.jj.davison@gmail.com>
The execute() API is async, it returns a promise. The FirefoxDomExecutor is synchronous, it 'sends' the command with dispatchEvent() and receives the response in the onResponse_ handler. Since we null the pendingCommand_ in the onResponse_ handler, we must save the the promise needed by the API before calling dispatchEvent(). Signed-off-by: Jason Juang <juangj@google.com>
The RemoteConnection resolves the hostname in the remote server's address to an IP in order to avoid the cost of looking up the IP on every request. This change enables IPv6 resolution; IPv4 is still preferred, so an IPv6 address is only returned in cases where the host is not available over IPv4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test