ci: install libslirp for ESP QEMU - #2215
Merged
Merged
Conversation
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review summary
Small, correct CI change: adds libslirp0 to the Linux embedded-deps install so the downloaded ESP QEMU binaries can dynamically load SLIRP for user-mode networking. Security, performance, and documentation passes found nothing to flag. One parity observation left inline.
No blocking issues.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
cpunion
changed the title
This was referenced Jul 29, 2026
cpunion
force-pushed
the
codex/ci-esp-qemu-libslirp
branch
from
July 29, 2026 22:42
060aea2 to
5b74a83
Compare
cpunion
changed the title
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The prebuilt ESP QEMU binaries dynamically link
libslirp.so.0, but Ubuntu runners do not provide it by default. Install thelibslirp0runtime package alongside SDL in the existing embedded-dependency setup action.The missing dependency fails before the build starts:
Validation
lddreports no missing libraries, and both binaries run--versionlibslirp0installedScope
This PR changes only the Ubuntu package installation. It does not change workflow timeouts, sharding, or job scheduling.