fix: move multi-cursor tokens to index.css - #178
Merged
Conversation
The multi-cursor plugin was defining :root tokens in its own CSS file, violating the convention that all design tokens live in index.css. Closes #171 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
claude
Bot
force-pushed
the
fix/171-multi-cursor-tokens
branch
from
February 22, 2026 21:12
698a884 to
81b4f77
Compare
Add multi-cursor tokens to design-tokens.md documentation per rule #6: "Update this doc when adding new tokens to index.css."
xulis
pushed a commit
to xulis/vmark
that referenced
this pull request
May 11, 2026
* fix: move multi-cursor tokens to index.css (source of truth) The multi-cursor plugin was defining :root tokens in its own CSS file, violating the convention that all design tokens live in index.css. Closes xiaolai#171 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: address review feedback for PR xiaolai#178 Add multi-cursor tokens to design-tokens.md documentation per rule xiaolai#6: "Update this doc when adding new tokens to index.css." --------- Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: xiaolai <lixiaolai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--multi-cursor-colorand--multi-cursor-selection-bgtoken definitions fromsrc/plugins/multiCursor/multi-cursor.csstosrc/styles/index.css(both:rootand.dark-themeblocks)var()fallback values in the plugin CSS — the tokens are now guaranteed to existWhy
Plugin CSS files should not write to
:root— design tokens belong inindex.css(the single source of truth). This eliminates a hidden CSS ordering dependency and follows the convention in.claude/rules/31-design-tokens.md.Test plan
Closes #171
🤖 Generated with Claude Code