ENH: dump runtime stats to cloud storage systems#243
Merged
aresnow1 merged 13 commits intoxorbitsai:mainfrom Mar 7, 2023
Merged
ENH: dump runtime stats to cloud storage systems#243aresnow1 merged 13 commits intoxorbitsai:mainfrom
aresnow1 merged 13 commits intoxorbitsai:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #243 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 35 35
Lines 1162 1162
Branches 222 222
=======================================
Hits 1159 1159
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
aresnow1
reviewed
Mar 6, 2023
python/xorbits/_mars/services/task/supervisor/tests/test_task_manager.py
Show resolved
Hide resolved
python/xorbits/_mars/services/task/supervisor/tests/test_task_manager.py
Show resolved
Hide resolved
Contributor
|
So we dump each subtask info into one file now? Is there a significant overhead? |
aresnow1
reviewed
Mar 6, 2023
2 tasks
Contributor
Author
Right. There'll be a file for each subtask. The overhead is about 7% when running on my laptop with TPC-H SF10. |
UranusSeven
force-pushed
the
enh/dump_task_info_to_cloud_storage
branch
from
3ed7a64 to
7db47d0
Compare
ChengjieLi28
approved these changes
Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue number
Resolves #214
Check code requirements