Skip to content

BLD: fix doc build#481

Merged
qianduoduo0904 merged 5 commits intoxorbitsai:mainfrom
UranusSeven:doc/doc_dep
May 30, 2023
Merged

BLD: fix doc build#481
qianduoduo0904 merged 5 commits intoxorbitsai:mainfrom
UranusSeven:doc/doc_dep

Conversation

@UranusSeven
Copy link
Contributor

What do these changes do?

Fix doc build.

Related issue number

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.3.2 milestone May 30, 2023
@aresnow1
Copy link
Contributor

Is there a way to test it in CI? Last commit passed all checks.

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #481 (fc3674d) into main (9464c48) will decrease coverage by 0.76%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #481      +/-   ##
==========================================
- Coverage   75.19%   74.43%   -0.76%     
==========================================
  Files         998      998              
  Lines       77474    77474              
  Branches    16093    16093              
==========================================
- Hits        58255    57669     -586     
- Misses      16821    18299    +1478     
+ Partials     2398     1506     -892     
Flag Coverage Δ
unittests 74.38% <ø> (-0.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 426 files with indirect coverage changes

@UranusSeven
Copy link
Contributor Author

Is there a way to test it in CI? Last commit passed all checks.

I haven't found a proper way to do it. But a workaround could be import your own fork-repo to build the docs and build the PR barnch before it got merged.

Copy link
Contributor

@qianduoduo0904 qianduoduo0904 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qianduoduo0904 qianduoduo0904 merged commit ec6f3ea into xorbitsai:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants