Skip to content

FEAT: Support base Index.str accessor#511

Merged
mergify[bot] merged 25 commits intoxorbitsai:mainfrom
RayJi01:feature/Index_str
Jun 26, 2023
Merged

FEAT: Support base Index.str accessor#511
mergify[bot] merged 25 commits intoxorbitsai:mainfrom
RayJi01:feature/Index_str

Conversation

@RayJi01
Copy link
Contributor

@RayJi01 RayJi01 commented Jun 9, 2023

What do these changes do?

These changes are intended to support the function of the Index.str framework similar to pandas.Index.str. Now the framework shall support the base method of Index.str such as Index. str. lower, upper, title, strip, count. Methods such as split or extract, which will modify the index structure, haven't been implemented yet but will soon come up.

Related issue number

Resolves #441

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.3.2 milestone Jun 9, 2023
@RayJi01 RayJi01 marked this pull request as draft June 9, 2023 06:43
@RayJi01 RayJi01 linked an issue Jun 9, 2023 that may be closed by this pull request
@RayJi01 RayJi01 changed the title FEAT: Support base Index_str method which won't change the index data-struc… FEAT: Support base Index_str method Jun 9, 2023
@UranusSeven UranusSeven changed the title FEAT: Support base Index_str method FEAT: Support base Index.str accessor Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #511 (a912aae) into main (90c9b74) will increase coverage by 7.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
+ Coverage   86.28%   93.32%   +7.04%     
==========================================
  Files        1003     1003              
  Lines       77698    77718      +20     
  Branches    16142    16145       +3     
==========================================
+ Hits        67038    72531    +5493     
+ Misses       9158     3496    -5662     
- Partials     1502     1691     +189     
Flag Coverage Δ
unittests 93.26% <100.00%> (+7.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/xorbits/core/data.py 100.00% <ø> (ø)
python/xorbits/_mars/dataframe/base/__init__.py 99.19% <100.00%> (+0.01%) ⬆️
python/xorbits/_mars/dataframe/base/accessor.py 100.00% <100.00%> (ø)
python/xorbits/_mars/dataframe/base/string_.py 98.34% <100.00%> (+0.48%) ⬆️
python/xorbits/_mars/dataframe/core.py 93.64% <100.00%> (-0.19%) ⬇️
python/xorbits/_mars/dataframe/utils.py 91.50% <100.00%> (-3.11%) ⬇️

... and 146 files with indirect coverage changes

@RayJi01 RayJi01 marked this pull request as ready for review June 13, 2023 03:24
Signed-off-by: Rui Ji <ruiji@usc.edu>
@RayJi01 RayJi01 requested a review from UranusSeven June 15, 2023 03:25
@RayJi01 RayJi01 requested review from aresnow1 and pangyoki June 26, 2023 07:48
Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RayJi01 RayJi01 requested a review from UranusSeven June 26, 2023 09:13
Copy link
Contributor

@pangyoki pangyoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 00f2f03 into xorbitsai:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FEAT: Support Index.str

5 participants