refactor(collections)!: rename namespace to XPHP\Collections#2
Merged
Conversation
Align the Composer package name (and the README title) with the plural GitHub repository slug, xphp-lang/collections. The PHP namespace XPHP\Collection is deliberately kept singular -- it is independent of the package name and renaming it would be a breaking API change. Metadata only; composer validate passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pluralize the PHP namespace root XPHP\Collection -> XPHP\Collections across src, tests, examples, the composer.json autoload prefixes, and ADR-0006/0008, aligning it with the plural package name and repository (xphp-lang/collections). The root class/interface `Collection` stays singular; only the namespace segment changes, and PSR-4 still maps the prefix to src/ + build/ (no directory move). Clean rebuild is green: check, 89 unit tests, PHPStan level 9, 100% MSI, demo. BREAKING CHANGE: consumers must update `use XPHP\Collection\...` to `use XPHP\Collections\...`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.