test: verify the benchmark regression gate (DO NOT MERGE) - #1
Closed
juicycleff wants to merge 1 commit into
Closed
Conversation
DO NOT MERGE. Adds four redundant passes over the input in histogramOp.Apply so the pull-request benchmark gate has a real regression to catch. Measured locally: +110% at n=100, +166% at n=1000, +177% at n=10000, all significant at p=0.002. scripts/bench-gate.sh exits 1 on this.
Contributor
Benchmark comparison |
juicycleff
added a commit
that referenced
this pull request
Aug 3, 2026
Verification on pull request #1 flagged Pipe/sort/n=1000 at +20.06% on a change that never touched sort. Same-runner comparison holds most benchmarks to +/-1-3%, but the tail reaches 20, so a 20% gate cries wolf. The deliberate regression in that same run measured +117% to +188%, so 30 costs no detection power. Also records the measured gate runtime of 2m48s, well under the estimate — -benchtime bounds each benchmark by wall clock, so total time tracks benchmark count rather than machine speed.
Contributor
Author
|
Verification complete — the gate works as intended. It correctly failed on the deliberate regression (+117% to +188%, p=0.002) and the whole run took 2m48s. It also surfaced one false positive: Closing without merging — this branch only ever existed to make the gate fire. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway PR — do not merge. Close once the gate is confirmed.
Exists to prove
.github/workflows/bench.ymlactually fails a pull request whenbenchmarks regress. A gate that has never been seen to fire is unverified.
What this changes
Four redundant passes over the input in
histogramOp.Apply, marked with aloud DO NOT MERGE comment. Nothing else.
Expected result
The Bench check should fail, with a comment on this PR showing roughly:
Measured locally against main at
-benchtime=100ms -count=6.If Bench passes, the gate is broken and needs fixing before it is trusted.
What this confirms
scripts/bench-gate.shreads the CSV and applies the 20% threshold🤖 Generated with Claude Code