Skip to content

Week of Sep 1#405

Merged
duglin merged 1 commit into
xregistry:mainfrom
duglin:Sep1
Sep 11, 2025
Merged

Week of Sep 1#405
duglin merged 1 commit into
xregistry:mainfrom
duglin:Sep1

Conversation

@duglin

@duglin duglin commented Sep 4, 2025

Copy link
Copy Markdown
Contributor
  • New text and moving more stuff around
  • add definition of "capabilities" attribute to Registry entity's list of attributes
  • add text about "views"

@duglin
duglin force-pushed the Sep1 branch 15 times, most recently from ce65f71 to 1008861 Compare September 11, 2025 11:50

@jskeet jskeet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only skimmed, and there are a few comments, but broadly speaking this looks fine to me.

Comment thread core/spec.md Outdated
Registry, while Groups, as the name implies, is a mechanism by which related
Resources are arranged together under a single collection.
Resources typically represent the main data of interest in the Registry, while
Groups, as the name implies, is a mechanism by which related Resources are

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I can see that it's a singular feature being described, the "Groups is a mechanism" jars a bit.

Would "while Groups, as the name implies, allow related Resources to be arranged together under a single collection" work?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

Comment thread core/spec.md Outdated

#### Group

Groups, as the name implies, is a mechanism by which related Resources are

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, another example of the same.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread core/spec.md
```

## Notations and Terminology
### Registry Views

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, GitHub is choosing a really odd diff here...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I guess that's what happens when you move too many large chunks of text around.

Wait for next week's PR... it'll be a doozy too

Comment thread core/spec.md Outdated
Comment on lines +559 to +562
In this view clients are retrieving all (or part) of the Registry hierarchy
as a single document. In this case nested (or child) entities are "inlined"
into the retrieved document such that the need for secondary interactions
with the server is reduced.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In this view clients are retrieving all (or part) of the Registry hierarchy
as a single document. In this case nested (or child) entities are "inlined"
into the retrieved document such that the need for secondary interactions
with the server is reduced.
In this view, clients are retrieving all (or part) of the Registry hierarchy
as a single document. In this case, nested (or child) entities are "inlined"
into the retrieved document such that the need for secondary interactions
with the server is reduced.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread core/spec.md Outdated
Resources, while possible, might be cumbersome, so moving it up to the Group
could be a more manageable, and user-friendly, implementation choice.
This is often used for cases where the documents are to be stored in some
document storage system (e.g. github), or as input into local tooling that

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
document storage system (e.g. github), or as input into local tooling that
document storage system (e.g. GitHub), or as input into local tooling that

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread core/spec.md Outdated
Additionally, Resources (unlike Groups) MAY be versioned.

#### Version
In this view it is assumed that the client is interested in an interactive

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In this view it is assumed that the client is interested in an interactive
In this view, it is assumed that the client is interested in an interactive

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread core/spec.md Outdated
- Multiple Document View

## Registry Design
This is a variant of the "api view". In situations where the data within the

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This is a variant of the "api view". In situations where the data within the
This is a variant of the "API view". In situations where the data within the

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread core/spec.md Outdated

## Registry Design
This is a variant of the "api view". In situations where the data within the
xRegistry is to be stored as independent files either on disk or in some

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be Registry?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done but it's a question I've been meaning to ask.... when do we use xRegistry vs Registry ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, I would prefer xRegistry, but above that, I prefer consistency (I'm a good student 😉)

Comment thread core/spec.md Outdated
This entity is meant to serve a few key purposes:
Documents generated in this view are often stored locally such that they can
be managed independently for use in tooling or stored in some source-code
control system (e.g. github) to minimize the number of conflicting edits

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
control system (e.g. github) to minimize the number of conflicting edits
control system (e.g. GitHub) to minimize the number of conflicting edits

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread core/spec.md
### Registry Views

This specification defines the following terms:
This specification is designed such that clients can choose how they want the

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be useful to mention the hasdoc aspect in this section as well, because it's mentioned through the ?doc, but it's not entirely clear at this point what that means.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it is mentioned just above, so maybe it's fine.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how the major "core vs http" split looks and see if we need to do it after that.

- New text and moving more stuff around
- add definition of "capabilities" attribute to Registry entity's list of attributes
- info about the different 'views'

Signed-off-by: Doug Davis <duglin@gmail.com>
@duglin

duglin commented Sep 11, 2025

Copy link
Copy Markdown
Contributor Author

Approved on the 9/11 call

@duglin
duglin merged commit 67d63e1 into xregistry:main Sep 11, 2025
2 checks passed
@duglin
duglin deleted the Sep1 branch September 11, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants