Message spec review#413
Merged
Merged
Conversation
duglin
reviewed
Oct 13, 2025
|
|
||
| This specification limits the number of versions of a message definition to | ||
| one, indicated by the `maxversions` attribute in the model. That means that a | ||
| message definition is not versioned, and should not be altered once it is |
Contributor
There was a problem hiding this comment.
SHOULD NOT
not even for typos or other non-on-the-wire changes?
Contributor
Author
There was a problem hiding this comment.
The challenge is that the specification then should define what constitutes an acceptable change.
duglin
reviewed
Oct 13, 2025
| adds another layer of complexity that can overcomplicate matching the right | ||
| message definition and schema. In addition, message definition metadata can be | ||
| relied upon by intermediaries and consumers, and changing a message | ||
| definition may break those. Therefore, a change in the message definition, |
duglin
reviewed
Oct 13, 2025
| relied upon by intermediaries and consumers, and changing a message | ||
| definition may break those. Therefore, a change in the message definition, | ||
| once it's flowing through a given system, is considered a breaking change, | ||
| which should be reflected by the introduction of a new message definition |
lailabougria
force-pushed
the
message-spec-review
branch
from
October 13, 2025 14:15
0b4a246 to
7f07a46
Compare
duglin
force-pushed
the
message-spec-review
branch
from
October 15, 2025 14:07
2af854d to
1572dec
Compare
Fixes xregistry#406 Signed-off-by: Clemens Vasters <clemens@vasters.com> Signed-off-by: Laila Bougria <laila@igindo.com>
duglin
force-pushed
the
message-spec-review
branch
from
October 15, 2025 14:14
ffcb9e1 to
9071629
Compare
Contributor
|
@clemensv please look over the edts to see if you're ok with them. In particular the stuff about maxversions |
Contributor
|
Approved on the 10/16 call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes