Week of Dec 1#425
Merged
Merged
Conversation
- More and better error messages Signed-off-by: Doug Davis <duglin@gmail.com>
duglin
force-pushed
the
Nov24
branch
2 times, most recently
from
December 3, 2025 01:01
a2f663c to
5842aee
Compare
Signed-off-by: Doug Davis <duglin@gmail.com>
…eaders Signed-off-by: Doug Davis <duglin@gmail.com>
Signed-off-by: Doug Davis <duglin@gmail.com>
Signed-off-by: Doug Davis <duglin@gmail.com>
Signed-off-by: Doug Davis <duglin@gmail.com>
Signed-off-by: Doug Davis <duglin@gmail.com>
jskeet
reviewed
Dec 4, 2025
|
|
||
| The `POST` variant when directed at a single entity, MUST adhere to the | ||
| following: | ||
| The `POST` variant when directed at a single entity (not a Resource), MUST |
There was a problem hiding this comment.
Suggested change
| The `POST` variant when directed at a single entity (not a Resource), MUST | |
| The `POST` variant when directed at a single entity other than a Resource, MUST |
(Just to clarify that this isn't claiming that resources aren't entities.)
| non-null value, the HTTP body MUST be empty. If the `<RESOURCE>url` | ||
| attribute is absent, then the contents of the HTTP body (even if empty) are | ||
| to be used as the entity's document. | ||
| - The `<RESOURCE>` and `<RESOURCEbase64>` attribute MUST never appear as |
There was a problem hiding this comment.
Suggested change
| - The `<RESOURCE>` and `<RESOURCEbase64>` attribute MUST never appear as | |
| - The `<RESOURCE>` and `<RESOURCEbase64>` attributes MUST never appear as |
| allow for [No-Code Servers](#no-code-servers) servers that might not be | ||
| able to control the HTTP response headers. | ||
|
|
||
| The `<RESOURCE>` and `<RESOURCEbase64>` attribute MUST NOT be serialized as |
There was a problem hiding this comment.
Suggested change
| The `<RESOURCE>` and `<RESOURCEbase64>` attribute MUST NOT be serialized as | |
| The `<RESOURCE>` and `<RESOURCEbase64>` attributes MUST NOT be serialized as |
| sub-trees into one result set and remove any duplicates - adjusting any | ||
| collection `url` and `count` values as needed. | ||
|
|
||
| ### `?ignore` Flag |
There was a problem hiding this comment.
This doesn't describe:
- What the flag is for or what it does
- What it means to have just
?ignorerather than?ignore=abc,xyz
(Linking to the core spec would cover these, but at least a single sentence would help to give an idea of what it's about, like we have for inline and filter.)
| * Type: `https://github.com/xregistry/spec/blob/main/core/spec.md#details_required` | ||
| * Code: `405 Method Not Allowed` | ||
| * Title: `$details suffix is needed when using PATCH for Resource: <subject>.` | ||
| * Title: `$details suffix is needed when using PATCH for entity: <subject>.` |
There was a problem hiding this comment.
Suggested change
| * Title: `$details suffix is needed when using PATCH for entity: <subject>.` | |
| * Title: `$details suffix is needed when using PATCH for an entity: <subject>.` |
| * Code: `400 Bad Request` | ||
| * Subject: `<request_path>` | ||
| * Title: `Can't sort on a non-collection result set. Query path: <subject>.` | ||
| * Detail: Suggestion: list of attributes that are too large. |
There was a problem hiding this comment.
I don't understand how this detail is relevant to this error. Not sure if this line is just in the wrong place?
Contributor
Author
There was a problem hiding this comment.
LOL - copy-n-paste error - good eye
Signed-off-by: Doug Davis <duglin@gmail.com>
Signed-off-by: Doug Davis <duglin@gmail.com>
Contributor
Author
|
Approved on the 12/4 call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also include text about ignoring the Resource-level attributes that might appear.
Fixes #427
Fixes #426
FIxes #428