Week of June 15#479
Conversation
ed735ee to
7a4d27a
Compare
ffc8c23 to
248ae01
Compare
jskeet
left a comment
jskeet
left a comment
There was a problem hiding this comment.
A few small comments, but fine as far as I understand it...
| ### `attributes.<STRING>.matchversions` | ||
| - Type: Boolean. | ||
| - OPTIONAL. | ||
| - Indicated whether all Versions of a Resource instance MUST have the same |
There was a problem hiding this comment.
| - Indicated whether all Versions of a Resource instance MUST have the same | |
| - Indicates whether all Versions of a Resource instance MUST have the same |
(I expect, anyway. It's odd to be in the past tense.)
| - Are statically defined. Meaning, not defined as part of a `ifvalues` clause | ||
| or via a `*` extension definition | ||
| - Are not defined within an array or map. Within an object is allowed. | ||
| - In the case of the attribute type being a `string`, the comparison MUST take |
There was a problem hiding this comment.
As in, if matchcase is false, then it's okay one version to have a value of "ABC" and another to have a value of "abc" without any errors being generated?
There was a problem hiding this comment.
yes. Do you think I need to be more clear/verbose on that?
There was a problem hiding this comment.
Nope, I think it's fine - just thought I'd double-check, as if it didn't mean that, we'd need to be clearer :)
There was a problem hiding this comment.
Perfect! Thanks SOOOO much for the quick review!
| ``` | ||
|
|
||
| Likewise, forcing all Resource instances to have "sticky" Versions MAY be | ||
| done via the same mechanism but using `true` instead of `false` in the |
There was a problem hiding this comment.
| done via the same mechanism but using `true` instead of `false` in the | |
| achieved via the same mechanism but using `true` instead of `false` in the |
Maybe? It just feels a little more spec-suitable than "done".
d4a8afd to
ac43694
Compare
- make 'constraints.equals' use 'matchcase' for strings - clarity that setting maxversions=1 when there are sticky versions -> error - tell people who to require sticky versions Signed-off-by: Doug Davis <duglin@gmail.com>
|
Approved off-line |
2 participants
Fixes #478
Fixes #477