Bump the engine and cut versionCode 85 - #84
Merged
Merged
Conversation
Moves the pinned engine 52 commits, from 9e29c1e to cd3051c. One of them is 374087a, the fix for the va_list bug behind the sitemap checkbox crashing the crawl on Android. HTTRACK_VERSIONID is still 3.49.14, so the versionName prefix does not change. The engine's source list did not move either, so Android.mk needs no edit, and no new command-line option turned up. Closes #82 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the pinned engine 52 commits to cd3051c and cuts versionCode 85. The bump brings in 374087a, the fix for the log-callback va_list bug that segfaulted the crawl when the sitemap checkbox was set in vc84, so this closes #82.
Engine version is still 3.49.14, so the versionName prefix stays. The build list and the option table did not move either, so nothing changes in Android.mk or the GUI wiring. I checked that the new engine actually linked by grepping the built libhttrack.so for a symbol new to the bump: 11 hits, against 0 in the vc84 .so.
Not device-tested. The sitemap arm has only ever been proven against a locally patched engine, never against this pin.