ci: pin the vcpkg version database per manifest - #87
Merged
Conversation
…seline Choosing the newest baseline by committer date was a proxy for ancestry: ties sort unstably and a non-monotonic date would silently select the older tree. The exact check, git merge-base --is-ancestor, cannot see across two --depth 1 fetches, so drop the comparison rather than try to repair it. Each manifest now gets versions/ checked out at its own pin, immediately before the build that consumes it. That also retires the assumption that the database is append-only enough for one tree to serve both baselines. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012gAp9x4L95B8DkeuHQpuqg Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picking the newest baseline by committer date was a proxy for ancestry, and a fragile one: ties sort unstably, and the exact check (
git merge-base --is-ancestor) cannot see across two--depth 1fetches. Rather than repair the comparison, this drops it. Each manifest getsversions/checked out at its own pin, right before the build that uses it.That also retires the shakier assumption behind #86, that the database is append-only enough for one tree to serve both baselines. It is not append-only in general, since port removals delete versions files; it just held across the two baselines we pin. Master now pins different baselines for the engine and the GUI, so an ordinary CI run exercises both checkouts.