Enable _FORTIFY_SOURCE and -fstack-protector-strong - #504
Merged
Conversation
The rest of the OpenSSF hardening set (stack-clash, cf-protection, relro/now, noexecstack, PIE, format-security) is already enabled; this fills the two gaps. Bundle autoconf-archive's AX_ADD_FORTIFY_SOURCE (serial 10: tries =3, falls back to =2, no-ops when the toolchain predefines it); distro copies can be too old (Debian trixie ships serial 4, =2 only). Skip fortify in -fsanitize builds, whose interceptors want the unfortified calls. Upgrade -fstack-protector to -strong, keeping the plain form as fallback. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the two flags missing from the OpenSSF hardening set (audit item P3-4):
_FORTIFY_SOURCE=3(falls back to=2; skipped when the toolchain predefines it or in-fsanitizebuilds, whose interceptors want the unfortified calls) and-fstack-protector-strong(plain-fstack-protectoras fallback). The rest of the list (stack-clash, cf-protection, relro/now, noexecstack, PIE, format-security) was already enabled.Bundles autoconf-archive's
AX_ADD_FORTIFY_SOURCEintom4/because distro copies can be too old: Debian trixie ships serial 4, which only knows=2.Verified: both flags reach every compile line, the warning set matches master (the same three warnings, now under their
__builtin___*_chkspellings),make checkpasses, andhardening-checkreports fortified functions in both the binary andlibhttrack.so.