Expose post-3.49-2 engine options in webhttrack#589
Merged
Conversation
The web GUI was frozen before the engine gained SOCKS5 proxying, --cookies-file, --pause, --strip-query, and the three --keep-* URL-hack opt-outs. Wire each into the option tabs, the generated httrack command, the winprofile.ini persistence, and the reload remap so they reach parity with WinHTTrack (xroche/httrack-windows#31). The SOCKS5 selector reuses the single proxy field and prepends socks5:// to -P; it is gated on a non-empty host so a SOCKS5-selected-but-blank config can't emit a stray scheme token. winprofile.ini key names match WinHTTrack so projects round-trip across both GUIs. Labels/tooltips reuse the LANG_ strings already added in #588. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
webhttrack was frozen before the engine gained SOCKS5 proxying,
--cookies-file,--pause,--strip-query, and the three--keep-*opt-outs of the-%uURL hack. This adds all of them to the web GUI, bringing it level with WinHTTrack (xroche/httrack-windows#31). Each option threads through the existing template machinery: a field on its option tab, the generatedhttrackcommand, thewinprofile.inithat persists the project, and the reload remap instep2. Thewinprofile.inikey names match WinHTTrack's, so a project saved in one GUI reloads in the other.The SOCKS5 selector reuses the single proxy field and prepends
socks5://to-P. It is gated on a non-empty host, so picking SOCKS5 with a blank proxy can't leak a straysocks5://token into the command. Labels and tooltips reuse theLANG_strings already translated across all 30 language files in #588.--whyis left out (a diagnose-and-exit mode, not a mirror setting), matching the Windows decision.Verified against a live
htsserverrender: the generated command, thewinprofile.ini, and the reload round-trip all behave, including the HTTP and empty-host edge cases.Closes #587