Drop the removed Java .class parser from the credits - #691
Merged
Conversation
The Java binary .class parser was removed in #552, but its credit lingered: "JavaParserClasses: Yann Philippot" in the WinHTTrack About box (lang.def plus every lang/*.txt), and "for the java binary .class parser" in greetings.txt and the contact page. Remove the About-box line and the now-defunct descriptor, keeping Yann Philippot's name in the developed-by acknowledgments. lang.def and lang/*.txt are read as strict line pairs, so the edit deletes the substring inside the single credits line rather than removing any line, keeping the pairing intact and each translated file's English msgid in lockstep with lang.def. Verified by tests/62_lang-integrity.test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
The About box shows the translation (msgstr), not the English msgid. The first pass only removed the literal English "JavaParserClasses: Yann Philippot", so the 12 files whose translators localized the credit (Chinese, French, Russian, Turkish, ...) still displayed it. Remove the localized credit line from each of those msgstrs too; the pairing and every English msgid are untouched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
Dropping the descriptor left a bare name in the developed-by list. Mark the java binary .class parser as a past contribution instead, keeping the acknowledgment meaningful now that the code is gone. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
The " dot " spelling is the page's email anti-harvest obfuscation; applied to a filename extension it just left a stray double space. The page already writes literal dots elsewhere (v2.0, v3.0). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
xroche
added a commit
to xroche/httrack-android
that referenced
this pull request
Jul 24, 2026
The engine deleted its Java .class parser in httrack#552; xroche/httrack#691 finally drops the stale "JavaParserClasses: Yann Philippot" line from the credits block (LANG_K1 and every translation). Mirror that here in the app's hand-maintained about_credits string so the About box matches upstream. Signed-off-by: Xavier Roche <roche@httrack.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Java binary .class parser was removed in #552, but its credit lingered in the WinHTTrack About box (lang.def plus every lang/*.txt, in both the English source and the localized translations the box actually displays) and in the developed-by lists in greetings.txt and the contact page. This drops the About-box credit in all languages and rewords Yann Philippot's acknowledgment as a past contributor.
lang.def and lang/*.txt are read as strict line pairs, so the edit removes the credit from within each credits line rather than deleting a line, keeping the pairing intact and every English msgid in lockstep with lang.def. Verified by tests/62_lang-integrity.test.