hts_finish_html_file is documented as skipping unchanged writes, and does not - #764
Merged
Conversation
…does not The MD5 comparison the comment promises left the tree in two steps: #467 extracted the function out of htsparse.c's HT_ADD_END macro without the skip branch, and #512 removed the //[HTML-MD5]// cache entry it read. Drop the parenthetical; the write is unconditional. Signed-off-by: Xavier Roche <roche@httrack.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hts_finish_html_file()'s header comment promises the write is skipped when the MD5 is unchanged. It is not: the function callsfile_notify(), thenfilecreate(), then writes, every time.The skip was real before #467, which lifted the code out of
htsparse.c'sHT_ADD_ENDmacro and carried the comment across without the hashing branch. #512 then dropped the//[HTML-MD5]//cache entry it compared against, so there is nothing left to reinstate it from. Behaviour is unchanged; only the comment moves.Closes #727