Skip to content

XEP-0319: Add a precision about the XEP-0082 profile used. - #469

Merged
jcbrand merged 3 commits into
xsf:masterfrom
linkmauve:xep-0234
Sep 6, 2017
Merged

XEP-0319: Add a precision about the XEP-0082 profile used.#469
jcbrand merged 3 commits into
xsf:masterfrom
linkmauve:xep-0234

Conversation

@linkmauve

Copy link
Copy Markdown
Member

No description provided.

@linkmauve linkmauve changed the title XEP-0234: Add a precision about the XEP-0082 profile used. XEP-0319: Add a precision about the XEP-0082 profile used. May 30, 2017
Comment thread xep-0319.xml
<revision>
<version>1.0.1</version>
<date>2017-05-30</date>
<initials>egp</initials>

@SamWhited SamWhited Jun 2, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: "Be precise about the XEP-0082 profile used" sounds a bit better; precision is not plural/singular, so you can't have "a precision" (I'm not sure what that rule is actually called). I wouldn't add a link in the remarks either, although I'm not actually sure if it's against the DTD or not. I guess not since Travis passed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-nit. You can have "A precision", e.g. "This is accurate to a precision of one Cochrane." ;)

@SamWhited SamWhited Jun 2, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes; good call. That's not using it in a plural / singular sense, so it works, but I can't actually figure out what the difference is… English is hard.

@horazont horazont added the Needs Council The affected XEP has the Council as Approving Body and it needs to decide on the change. label Aug 24, 2017
@horazont

horazont commented Sep 1, 2017

Copy link
Copy Markdown
Contributor

Voting started on 2017-08-30, voting period ends on 2017-09-13.

@jcbrand

jcbrand commented Sep 4, 2017

Copy link
Copy Markdown
Contributor

Voting started on 2017-08-30, voting period ends on 2017-09-13.

Everyone except the author (@linkmauve), who wasn't present, has already voted on this. Can we assume @linkmauve's consent or should we wait for Wednesday's meeting?

@jcbrand jcbrand self-assigned this Sep 4, 2017
@jcbrand jcbrand added Ready To Merge No acknowledgements of other parties are needed anymore. There may be changes to do at merge time. and removed Needs Council The affected XEP has the Council as Approving Body and it needs to decide on the change. labels Sep 6, 2017
@jcbrand

jcbrand commented Sep 6, 2017

Copy link
Copy Markdown
Contributor

@linkmauve Has now also voted +1. That means everyone has voted.

https://mail.jabber.org/pipermail/standards/2017-September/033237.html

@jcbrand
jcbrand merged commit be7cb4d into xsf:master Sep 6, 2017
@horazont

Copy link
Copy Markdown
Contributor

@jcbrand Did you intentionally omit sending the email for this change?

@linkmauve
linkmauve deleted the xep-0234 branch September 11, 2017 19:03
@jcbrand

jcbrand commented Sep 11, 2017

Copy link
Copy Markdown
Contributor

@horazont I followed your instructions in the README and did the --dry-run command, but got no output. So it looked to me like no email has to be sent and I therefore assumed that emails are only sent out for XEPs whose statuses change (e.g. from ProtoXEP to experimental).

I'll give it another shot tomorrow.

@jcbrand

jcbrand commented Sep 12, 2017

Copy link
Copy Markdown
Contributor

@horazont The email has now been sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready To Merge No acknowledgements of other parties are needed anymore. There may be changes to do at merge time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants