Skip to content

Update mlir-opt path resolution and opt/llc flags#105

Merged
guillon merged 4 commits into
xtc-tools:mainfrom
guillon:dev/cguillon/fix-mlir-and-opts
Jul 22, 2026
Merged

Update mlir-opt path resolution and opt/llc flags#105
guillon merged 4 commits into
xtc-tools:mainfrom
guillon:dev/cguillon/fix-mlir-and-opts

Conversation

@guillon

@guillon guillon commented Jul 21, 2026

Copy link
Copy Markdown
Member

Motivation

Fix unexpected behavior update flags in opt/llc.

Description

Fixes:

  • mlir-opt: fix path search for mlir-opt in case of llvm/mlir local build
  • codecov: make low patch coverage only informational (i.e. does not fail CI) as a patch coverage on previously low covered code may be very low

Changes:

  • remove use of fast-math options which are too aggressive and incompatible with recent mlir opt versions
  • change -O3 to -O2 in llc/opt in order to better preserve expected schedule

Discussions

Loop explore has been rerun on matmul (stratgey tile8dv) against tvm and previous version:

  • no visible build time change
  • no regression on top performance (~92% peak perf on an avx512 laptop) and overall search space distribution
  • some expected regression on points where llc unrolled more and gained performance against tvm
  • code size gain as opt/llc do not perform aggressive loop unrolling

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/xtc/utils/tools.py 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@guillon
guillon requested a review from qaco July 21, 2026 23:58
@guillon guillon added the enhancement New feature or request label Jul 21, 2026
Actually -O3 activates unexpected additional optimizations such as unrolling.
We want to avoid this as much as possible in order to match requested schedule.
@guillon
guillon force-pushed the dev/cguillon/fix-mlir-and-opts branch from 9e8a93f to 604be8a Compare July 22, 2026 00:07
@guillon guillon changed the title Update mlir opt resolution and other fixes Update mlir-opt path resolution and opt/llc flags Jul 22, 2026
@qaco

qaco commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Nice!

@guillon
guillon merged commit 703d5db into xtc-tools:main Jul 22, 2026
4 checks passed
@guillon
guillon deleted the dev/cguillon/fix-mlir-and-opts branch July 22, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants