Fix: error with slice when using descript_scheduler#27
Merged
qaco merged 1 commit intoxtc-tools:mainfrom Mar 4, 2026
Merged
Conversation
Contributor
|
Cool ! Do you want to dig into the bug (probably in descript.py) and fix it in the same PR ? It could be a good exercise to discover XTC deeper. If you prefer, I can do it. |
Contributor
Author
|
I want to try to fix it |
yadej
force-pushed
the
dev/rcesista/spec_schedule_bug
branch
from
ebd6146 to
98b2aff
Compare
yadej
changed the title
qaco
reviewed
Jan 30, 2026
qaco
reviewed
Jan 30, 2026
yadej
force-pushed
the
dev/rcesista/spec_schedule_bug
branch
from
98b2aff to
3ab1ee6
Compare
yadej
commented
Feb 3, 2026
qaco
reviewed
Feb 3, 2026
qaco
reviewed
Feb 3, 2026
yadej
force-pushed
the
dev/rcesista/spec_schedule_bug
branch
from
0120f52 to
97e5311
Compare
qaco
reviewed
Feb 25, 2026
qaco
reviewed
Feb 25, 2026
qaco
reviewed
Feb 25, 2026
qaco
reviewed
Feb 25, 2026
qaco
reviewed
Feb 25, 2026
Contributor
|
Sorry for the delay. It is great work. This new round of comments focuses on separation of concerns. |
qaco
reviewed
Feb 26, 2026
Member
Contributor
Member
Contributor
|
@yadej could you please squash your commits ? Once it's done, I merge the branch ! |
descript_scheduler - Add test to descript_scheduler with slice
yadej
force-pushed
the
dev/rcesista/spec_schedule_bug
branch
from
5b98628 to
4c39966
Compare
Contributor
Author
|
The commit has been squashed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a minimal failing example for descript_scheduler
Discussion of the error is in that issue #26