runtimes: added check_compile to detect libpfm4-dev#50
runtimes: added check_compile to detect libpfm4-dev#50guillon merged 1 commit intoxtc-tools:mainfrom
Conversation
|
I think we need to fix #43 first. |
|
@liamsemeria Can you add the motivation, use case for this PR in the description? Originally, I wanted to have the least set of dependencies for XTC to work, i.e. if not installed/available the hw counter just return 0. Do you think there would be a motivation to change this? |
|
@guillon I updated the motivation. When installing xtc on my computer, I'm pretty sure none of the tests were passing without it installed, and simple xtc examples weren't working. |
|
@liamsemeria ok, I understand. I think that th problem comes from the fact that one may have:
So basically, what is wrong:
Do you think you could contribute this? |
|
@guillon Yeah I can. Seems like I would then use that similar to |
Yes, as explained what I did there was not actually sufficient to detect a "dev" package, you need to test the presence of the lib and of the include files. |
428dbd8 to
7b91b0f
Compare
|
@guillon I added the check_compile, it fixed the issue and all tests pass independent of whether or not a libpfm4 is installed/ |
dbl importy ting
7b91b0f to
632886e
Compare
|
@guillon fixed the double import |
guillon
left a comment
There was a problem hiding this comment.
Thanks a lot for this change! Great
Motivation:
xtc wasn't working without it installed because of
perfmonincludes in the runtime.