XRENDERING-799: Macro inside link isn't parsed as inline macro #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Transform macros to inline in InlineFilterListener. * Add a test for InlineFilterListener. * Add an integration test for the XWiki 2.0 parser.
michitux
requested review from
Copilot and
tmortagne
and removed request for
Copilot
tmortagne
approved these changes
Nov 6, 2025
Contributor
Author
|
@tmortagne Any comment regarding backporting to LTS version(s)? |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 7, 2025
* Transform macros to inline in InlineFilterListener. * Add a test for InlineFilterListener. * Add an integration test for the XWiki 2.0 parser. (cherry picked from commit 4c7e0f4)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 7, 2025
* Transform macros to inline in InlineFilterListener. * Add a test for InlineFilterListener. * Add an integration test for the XWiki 2.0 parser. (cherry picked from commit 4c7e0f4)
This was referenced Nov 7, 2025
Merged
michitux
added a commit
that referenced
this pull request
Nov 7, 2025
* Transform macros to inline in InlineFilterListener. * Add a test for InlineFilterListener. * Add an integration test for the XWiki 2.0 parser. (cherry picked from commit 4c7e0f4)
michitux
added a commit
that referenced
this pull request
Nov 7, 2025
* Transform macros to inline in InlineFilterListener. * Add a test for InlineFilterListener. * Add an integration test for the XWiki 2.0 parser. (cherry picked from commit 4c7e0f4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XRENDERING-799
Changes
Description
Clarifications
Screenshots & Video
The example from the Jira issue:
Before:
After:
Executed Tests
Built the whole
xwiki-renderingwithLANG=C.UTF-8 mvn clean install -Pdocker,legacy,integration-tests,snapshotModules,quality,distributionExpected merging strategy