You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(gen-palette): break cyclic model parent chains before render
Sanitize the model pool after pack load: walk each model's `parent` chain
with a `seen` set and snip the edge that would close a cycle. fastanvil
0.32's `Renderer::flatten_model` walks parents without cycle detection,
so a single self-referential model (e.g. Control Craft Forge's
`vscontrolcraft:block/propeller_controller/block`) caused
`Renderer::get_top` to spin forever, hanging gen-palette indefinitely on
any modpack containing it. The 12-min timeout in our test corpus surfaced
this as `gen_palette_timeout` for both valkyriens and create_train.
The snipped model still has its own elements/textures, so tier 1
rendering succeeds normally — the parent edge would have inherited those
identically anyway.
Resolution mirrors fastanvil's `get_model` (try as-is, then `minecraft:`
prefix) so cycles spanning the implicit-namespace gap are caught too.