Skip to content

build(deps): Bump go-task to 3.48.0 (fixes #250); Move go-task installation into a reusable GH action; Move docs tasks under dedicated task file directory.#297

Merged
Bill-hbrhbr merged 4 commits intoy-scope:mainfrom
Bill-hbrhbr:bump-go-task-3.48
Apr 4, 2026

Conversation

@Bill-hbrhbr
Copy link
Copy Markdown
Contributor

@Bill-hbrhbr Bill-hbrhbr commented Apr 4, 2026

Description

As title.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

  • CI pass.

Summary by CodeRabbit

  • Documentation

    • Updated dependency version requirements in README: Python (>= 3.10), Task (>= 3.48.0), and uv (>= 0.7.0). Removed internal workaround note.
  • Chores

    • Reorganized internal build tooling, including GitHub Actions workflows and task configurations.

@Bill-hbrhbr Bill-hbrhbr requested review from a team and sitaowang1998 as code owners April 4, 2026 13:13
@Bill-hbrhbr Bill-hbrhbr requested a review from junhaoliao April 4, 2026 13:13
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 4, 2026

Walkthrough

A composite GitHub Action for installing go-task at version 3.48.0 is created and adopted across three workflows. Version constraints in documentation are relaxed, and taskfile configuration is standardized to use a template variable for root taskfile references instead of hardcoded paths.

Changes

Cohort / File(s) Summary
GitHub Actions
.github/actions/install-go-task/action.yaml
New composite action created to encapsulate go-task installation with version 3.48.0.
Workflow Updates
.github/workflows/code-linting-checks.yaml, .github/workflows/tdl-generated-code-checks.yaml, .github/workflows/tests.yaml
Three workflows updated to use the new local composite action instead of external go-task/setup-task action, removing explicit version configuration from workflows.
Documentation
README.md
Version constraints relaxed: Python to ">= 3.10", Task to ">= 3.48.0" (removing upstream issue reference), uv to ">= 0.7.0". Formatting cleanup applied.
Taskfile Configuration
taskfile.yaml
Includes reference for docs tasks updated from docs/tasks.yaml to taskfiles/docs.yaml.
Taskfile Source Updates
taskfiles/docs.yaml, taskfiles/lint.yaml, taskfiles/test.yaml, taskfiles/toolchains.yaml
Source entries standardized to use {{.ROOT_TASKFILE}} template variable instead of hardcoded {{.ROOT_DIR}}/taskfile.yaml path across four taskfiles.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title comprehensively describes the three main changes: bumping go-task to 3.48.0 (with issue reference), creating a reusable GitHub Action for installation, and reorganizing docs tasks into a dedicated directory.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Bill-hbrhbr Bill-hbrhbr linked an issue Apr 4, 2026 that may be closed by this pull request
3 tasks
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@taskfiles/test.yaml`:
- Around line 53-56: The root cause is that the templated variable ROOT_TASKFILE
referenced in taskfiles/test.yaml (and other taskfiles) is undefined; fix it by
adding a ROOT_TASKFILE entry under the root taskfile's vars: section (e.g.,
vars: { ROOT_TASKFILE: "path/to/root/taskfile.yaml" }) or by replacing all
occurrences of {{.ROOT_TASKFILE}} with the concrete path string; update the root
taskfile's vars block (or the usages in taskfiles/*) so the symbol ROOT_TASKFILE
is defined and consistently referenced.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: fd1b3d07-f089-40ed-962c-1b83896d7fa3

📥 Commits

Reviewing files that changed from the base of the PR and between 0399760 and 26da39f.

📒 Files selected for processing (10)
  • .github/actions/install-go-task/action.yaml
  • .github/workflows/code-linting-checks.yaml
  • .github/workflows/tdl-generated-code-checks.yaml
  • .github/workflows/tests.yaml
  • README.md
  • taskfile.yaml
  • taskfiles/docs.yaml
  • taskfiles/lint.yaml
  • taskfiles/test.yaml
  • taskfiles/toolchains.yaml

Comment thread taskfiles/test.yaml
@Bill-hbrhbr Bill-hbrhbr merged commit af7e0d8 into y-scope:main Apr 4, 2026
7 checks passed
@Bill-hbrhbr Bill-hbrhbr deleted the bump-go-task-3.48 branch April 4, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unlock task version once upstream issues are resolved

2 participants