feat(ci): Bump yscope-dev-utils to y-scope/yscope-dev-utils@38bf51e; Add coverage for building docs; Bump actions/checkout to v6.0.2; Fix task paths in taskfiles/docs.yaml.#298
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughRemoved a repo composite action that installed go-task; added a docs workflow; switched workflows to a pinned checkout SHA and repository-local install/log actions under Changes
Sequence Diagram(s)sequenceDiagram
participant GH as GitHub
participant Runner as Runner (macOS/Ubuntu)
participant Checkout as "actions/checkout (pinned)"
participant LocalActions as "repo-local actions (tools/yscope-dev-utils)"
participant Task as "task (go-task)"
participant Sphinx as Sphinx
GH->>Runner: trigger workflow (push/PR/cron/dispatch)
Runner->>Checkout: checkout repo (recursive submodules)
Runner->>LocalActions: run install-python, install-go-task, install-uv, log-tool-versions
Runner->>Task: execute task docs:${matrix.task}:site
Task->>Sphinx: invoke Sphinx --conf-dir "{{.SRC_DIR}}/conf" "{{.SRC_DIR}}/src" "{{.OUTPUT_DIR}}"
Sphinx-->>Runner: produce site artifacts / logs
Runner-->>GH: upload artifacts / report status
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/actions/repo-checkout/action.yaml:
- Around line 1-10: The composite local action "repo-checkout" is being
referenced before the repo is checked out; replace every use of the local
composite action (./.github/actions/repo-checkout) in the workflows (tests.yaml,
code-linting-checks.yaml, tdl-generated-code-checks.yaml, docs.yaml) with a
direct checkout step that uses
actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd and include with:
submodules: "recursive" so the runner can resolve files; remove the bootstrap
usage of the local composite action entirely so checkout happens first and
workflows no longer fail with "Can't find action.yaml/action.yml".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 31ba06d9-a547-46a2-b78e-6433ef6164f0
📒 Files selected for processing (6)
.github/actions/install-go-task/action.yaml.github/actions/repo-checkout/action.yaml.github/workflows/code-linting-checks.yaml.github/workflows/docs.yaml.github/workflows/tdl-generated-code-checks.yaml.github/workflows/tests.yaml
taskfiles/docs.yaml.
taskfiles/docs.yaml.checkout to v6.0.2 and setup-python to v6.2.0; Fix task paths in taskfiles/docs.yaml.
checkout to v6.0.2 and setup-python to v6.2.0; Fix task paths in taskfiles/docs.yaml.actions/checkout to v6.0.2 and actions/setup-python to v6.2.0; Fix task paths in taskfiles/docs.yaml.
actions/checkout to v6.0.2 and actions/setup-python to v6.2.0; Fix task paths in taskfiles/docs.yaml.actions/checkout to v6.0.2; Fix task paths in taskfiles/docs.yaml.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/tdl-generated-code-checks.yaml (1)
25-27: Explicitly set the Java version in the install-java action.The
install-javacomposite action exposes aversioninput parameter (default:11), but the workflow on line 25 does not set it explicitly. To prevent parser generation from drifting if the default version changes, add the version parameter:- uses: "./tools/yscope-dev-utils/exports/github/actions/install-java" with: version: "11"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/tdl-generated-code-checks.yaml around lines 25 - 27, The workflow uses the composite action "install-java" without explicitly setting its version input; update the step that uses "./tools/yscope-dev-utils/exports/github/actions/install-java" to include the with: version: "11" parameter so the Java major version is pinned (do not change the "install-go-task" step).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/tdl-generated-code-checks.yaml:
- Around line 25-27: The workflow uses the composite action "install-java"
without explicitly setting its version input; update the step that uses
"./tools/yscope-dev-utils/exports/github/actions/install-java" to include the
with: version: "11" parameter so the Java major version is pinned (do not change
the "install-go-task" step).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: cc1ef391-3c1d-478c-868c-ef08d13360b6
📒 Files selected for processing (2)
.github/workflows/tdl-generated-code-checks.yamltools/yscope-dev-utils
🚧 Files skipped from review as they are similar to previous changes (1)
- tools/yscope-dev-utils
actions/checkout to v6.0.2; Fix task paths in taskfiles/docs.yaml.actions/checkout to v6.0.2; Fix task paths in taskfiles/docs.yaml.
LinZhihao-723
left a comment
There was a problem hiding this comment.
Approved on behave of the code owner. Didn't check the content as @sitaowang1998 should have already reviewed.
Description
#297 broke paths in the
taskfiles/docs.yamldue to file relocation. This PR fixes those paths and adds CI coverage for docs builds so potential issues will be caught in future PRs.Checklist
breaking change.
Validation performed
Summary by CodeRabbit
New Features
Chores
Chores