feat(helm): Adds log_level support for storage, scheduler and worker. - #422
Conversation
WalkthroughHelm defaults now define log levels for execution-manager, scheduler, and storage containers. Deployment templates expose those values through ChangesHelm logging configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| - name: "RUST_LOG" | ||
| value: {{ .Values.spiderConfig.execution_manager.log_level | quote }} | ||
| {{- with .Values.spiderConfig.worker.extra_envs }} |
There was a problem hiding this comment.
env and extra_evns?
Let's discuss, I think I am okay with the change in this PR, but might worth some refactoring for the extra_envs, extra_volumn_mounts and extra_volumn
There was a problem hiding this comment.
We reached the following conclusion during offline discussion:
- Storage and scheduler should not accept extra environment variables for safety.
- Worker should have a standalone
log_levelinstead of usingextra_envsto:- Keep the same form as with storage and scheduler.
- Avoid user accidentally overwriting the log level when adding new environment variables.
There was a problem hiding this comment.
I agree with the decision to split the log level to the default env.
LinZhihao-723
left a comment
There was a problem hiding this comment.
Before merge: I think you should make the scope consistent with other PRs. Looks like we were always using feat(helm), not feat(spider-helm).
log_level support for storage, scheduler and worker.log_level support for storage, scheduler and worker.
Description
This PR adds support for setting log level in storage, scheduler and worker services by:
log_levelfield invalues.yamlfor all three services, default toINFO.RUST_LOGin env for all three services using the correspondinglog_level.Checklist
breaking change.
Validation performed
RUST_LOGset toINFOfor all three pods by default.kubectl logs.Summary by CodeRabbit
New Features
INFOlog-level settings to the deployment configuration.Chores