Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e2d37dd737
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| IRInstruction::Pack { type_id } => { | ||
| let item = program | ||
| .structs | ||
| .get(type_id.id()) | ||
| .expect("struct type not found"); |
There was a problem hiding this comment.
The new IRInstruction::Pack variant requires both type_id and field_count, so this pattern omits a required field; it then accesses program.structs, although IRProgram has no such member. Consequently, every build of this commit fails before any struct program can be lowered or interpreted. Destructure and use the field_count already embedded in the instruction instead.
Useful? React with 👍 / 👎.
1 participant
No description provided.