Karma Init by sovkay · Pull Request #1557 · yabwe/medium-editor

sovkay · 2020-07-26T08:27:13Z

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
New tests added?	not needed
License	MIT

Description

--

Please, don't submit `/dist` files with your PR!

sovkay · 2020-07-26T10:17:12Z

#1552

Tests passing again!
Browser-Stack being utilized.

Some tests are not passing!

sovkay · 2020-07-26T10:39:41Z

Firefox has errors which related to execAction(font props) of Core-API.

fontSize support old style
fontName support new stle
fontSize support new stle
fontName support old style

Not related to fonts probably!

should pass opt directly to document.execCommand

Firefox 78.0 (Windows 10): Executed 617 of 617 (5 FAILED) (18.184 secs / 10.708 secs)
TOTAL: 5 FAILED, 612 SUCCESS


1) fontSize support old style
     Core-API execAction
     TypeError: MediumEditor.util.getContainerEditorElement(...).focus is not a function in src/js/core.js (line 962)
execAction@src/js/core.js:962:94
@spec/core-api.spec.js:239:20
<Jasmine>

2) fontName support new stle
     Core-API execAction
     TypeError: MediumEditor.util.getContainerEditorElement(...).focus is not a function in src/js/core.js (line 962)
execAction@src/js/core.js:962:94
@spec/core-api.spec.js:225:20
<Jasmine>

3) fontSize support new stle
     Core-API execAction
     TypeError: MediumEditor.util.getContainerEditorElement(...).focus is not a function in src/js/core.js (line 962)
execAction@src/js/core.js:962:94
@spec/core-api.spec.js:253:20
<Jasmine>

4) fontName support old style
     Core-API execAction
     TypeError: MediumEditor.util.getContainerEditorElement(...).focus is not a function in src/js/core.js (line 962)
execAction@src/js/core.js:962:94
@spec/core-api.spec.js:211:20
<Jasmine>

5) should pass opt directly to document.execCommand
     Core-API execAction
     TypeError: MediumEditor.util.getContainerEditorElement(...).focus is not a function in src/js/core.js (line 962)
execAction@src/js/core.js:962:94
@spec/core-api.spec.js:197:20
<Jasmine>


TOTAL: 5 FAILED, 612 SUCCESS

sovkay · 2020-07-26T10:41:47Z

Safari

Resolved.

Well, It sucks, I don't have a Mac to debug these.

Safari 8.0.8 (Mac OS 10.10.5): Executed 619 of 617 (4 FAILED) (3.472 secs / 3.6 secs)
TOTAL: 4 FAILED, 615 SUCCESS


1) should close the font name form when user clicks on cancel
     Font Name Button TestCase Cancel
     IndexSizeError: DOM Exception 1: Index or size was negative, or greater than the allowed value. thrown

2) should close the font name form when user clicks on cancel
     Font Name Button TestCase Cancel
     IndexSizeError: DOM Exception 1: Index or size was negative, or greater than the allowed value. thrown
     TypeError: undefined is not a function (evaluating 'this.cleanupTest()') in spec/fontname.spec.js (line 26)
spec/fontname.spec.js:26:25
<Jasmine>

3) should close the font size form when user clicks on cancel
     Font Size Button TestCase Cancel
     IndexSizeError: DOM Exception 1: Index or size was negative, or greater than the allowed value. thrown

4) should close the font size form when user clicks on cancel
     Font Size Button TestCase Font Size
     IndexSizeError: DOM Exception 1: Index or size was negative, or greater than the allowed value. thrown
     TypeError: undefined is not a function (evaluating 'this.cleanupTest()') in spec/fontsize.spec.js (line 26)
spec/fontsize.spec.js:26:25
<Jasmine>


TOTAL: 4 FAILED, 615 SUCCESS

Edit: Was cause of CSS files not being included in srcFiles in Karma Config.

sovkay

Might be better if we create a util, isEmpty(obj) to check that. Or this is just fine, I guess.

sovkay · 2020-07-27T13:43:40Z

IE is used by <2% users in the world. I think we should just drop it.
@roniemartinez @arteconceito
What you think about IE support!

63% uses chrome
19% uses safari
8% Firefox
=> Greater than 90%
Browser Share from 2015-2020

arteconceito · 2020-07-27T14:29:29Z

IE is used by <2% users in the world. I think we should just drop it.
@roniemartinez What you think about IE support!

Browser Share

In general public usage yes but believe me, there are still many companies (I mean at the enterpise level) that still and only use IE 11.
I suppose this should be more a question of... Do we want to support it or not?

By the way, nice work with the tests migration. Unfortunately, I could not yet find the time I wished to contribute to the project!

sovkay · 2020-07-27T14:47:12Z

Yeah, I think the same too.

I think we should go for v10 and v11 as most people used to use ME cause it used to support all browsers.

Yeah, I got some free time(more like spirit than time) to do this. As i barely write tests.

And I'm still clueless on debugging these tests on IE and supporting them.

@arteconceito Direct me? I'll try to do it.

arteconceito · 2020-07-27T15:48:48Z

@sauravkhdoolia in my opinion supporting IE v11 is good enough and should cover most of IE user base as of today.

In order to debug IE I usually use a VM running IE11 on it. Firebug is also a good debugging extension as IE dev tools are not the best.

sovkay · 2020-07-27T15:50:04Z

I'll start there. Thanks brother.

sovkay · 2020-07-30T08:27:13Z

Hey @arteconceito It works on IE11 sometimes and sometimes it doesn't.

That is so weird to catch, Why sometimes an API is available in the IE browser, and sometimes it's not.

Here:

sovkay · 2020-07-30T08:33:06Z

@arteconceito It works in IE11, but sometimes it doesn't.

I don't know why?

Here:

sovkay · 2020-07-30T10:56:32Z

IE Errors found on BrowserStack.

IE 11.0 (Windows 10): Executed 617 of 617 (2 FAILED) (20.473 secs / 12.935 secs)
TOTAL: 2 FAILED, 615 SUCCESS


1) should change font name when select is changed
     Font Name Button TestCase Font Name
     Error: <toHaveBeenCalledWith> : Expected a spy, but got Function.
Usage: expect(<spyObj>).toHaveBeenCalledWith(...arguments)
Error: <toHaveBeenCalledWith> : Expected a spy, but got Function.
Usage: expect(<spyObj>).toHaveBeenCalledWith(...arguments)
    at <Jasmine>
   at Anonymous function (spec/fontname.spec.js:70:13)
    at <Jasmine>

2) should revert font name when select value is set to empty
     Font Name Button TestCase Font Name
     Error: <toHaveBeenCalledWith> : Expected a spy, but got Function.
Usage: expect(<spyObj>).toHaveBeenCalledWith(...arguments)
Error: <toHaveBeenCalledWith> : Expected a spy, but got Function.
Usage: expect(<spyObj>).toHaveBeenCalledWith(...arguments)
    at <Jasmine>
   at Anonymous function (spec/fontname.spec.js:104:13)
    at <Jasmine>


TOTAL: 2 FAILED, 615 SUCCESS

sovkay added 6 commits July 26, 2020 13:55

Karma Init

dd25548

Karma Conf

810b999

Coverage

fa3ea81

Coverage on Unit

69dae1d

Tests working

801cb74

Correcting Tests

9f5f11a

sovkay linked an issue Jul 26, 2020 that may be closed by this pull request

Major To-Do #1552

Open

9 tasks

sovkay added 2 commits July 26, 2020 17:53

Firefox Focus without Selection__Correction

a8c033d

Added Edge and Firefox to karma config

ba35736

sovkay commented Jul 26, 2020

View reviewed changes

Comment thread src/js/core.js

sovkay removed a link to an issue Jul 27, 2020

Major To-Do #1552

Open

9 tasks

sovkay added 3 commits July 27, 2020 18:01

Safari Tests Passing

c40c286

Maxm Log length resolve: Different karma conffiles

390fac6

Removing Extra browsers

a7161c0

sovkay added the tests label Jul 30, 2020

sovkay merged commit 2c0af6b into master Aug 2, 2020

j0k3r deleted the karma branch October 24, 2024 07:27

Navigation Menu

Uh oh!

Karma Init - #1557

Karma Init#1557
sovkay merged 11 commits into
masterfrom
karma

sovkay commented Jul 26, 2020 •

edited

Loading

Uh oh!

sovkay commented Jul 26, 2020 •

edited

Loading

Uh oh!

sovkay commented Jul 26, 2020 •

edited

Loading

Uh oh!

sovkay commented Jul 26, 2020 •

edited

Loading

Uh oh!

sovkay left a comment

Uh oh!

Uh oh!

sovkay commented Jul 27, 2020 •

edited

Loading

Uh oh!

arteconceito commented Jul 27, 2020

Uh oh!

sovkay commented Jul 27, 2020 •

edited

Loading

Uh oh!

arteconceito commented Jul 27, 2020

Uh oh!

sovkay commented Jul 27, 2020

Uh oh!

sovkay commented Jul 30, 2020

Uh oh!

sovkay commented Jul 30, 2020

Uh oh!

sovkay commented Jul 30, 2020 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

sovkay commented Jul 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Please, don't submit /dist files with your PR!

Uh oh!

sovkay commented Jul 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sovkay commented Jul 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sovkay commented Jul 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sovkay left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sovkay commented Jul 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arteconceito commented Jul 27, 2020

Uh oh!

sovkay commented Jul 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arteconceito commented Jul 27, 2020

Uh oh!

sovkay commented Jul 27, 2020

Uh oh!

sovkay commented Jul 30, 2020

Uh oh!

sovkay commented Jul 30, 2020

Uh oh!

sovkay commented Jul 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sovkay commented Jul 26, 2020 •

edited

Loading

Please, don't submit `/dist` files with your PR!

sovkay commented Jul 26, 2020 •

edited

Loading

sovkay commented Jul 26, 2020 •

edited

Loading

sovkay commented Jul 26, 2020 •

edited

Loading

sovkay commented Jul 27, 2020 •

edited

Loading

sovkay commented Jul 27, 2020 •

edited

Loading

sovkay commented Jul 30, 2020 •

edited

Loading