Skip to content

Closes 254 - #260

Merged
yakew7 merged 2 commits into
yakew7:mainfrom
propcgamer20-png:main
Aug 14, 2026
Merged

Closes 254#260
yakew7 merged 2 commits into
yakew7:mainfrom
propcgamer20-png:main

Conversation

@propcgamer20-png

Copy link
Copy Markdown
Contributor

Solved issue - closes #254

The reference-deviation table had cells but no scope="col" or

. The other two tables in faircode/report.py - the main per-column breakdown table and the drift-comparison table - had no header row at all, a bigger gap than the issue described.

Added a / row plus a to all three
tables, in both to_html and compare_to_html, with matching th/caption
CSS in each report's embedded stylesheet. Caption text stands on its
own since the report is often shared outside the page it was
generated on (CI output, email, a PR comment).

Verified against real generated reports (faircode profile/compare
--html): all three tables render correctly, HTML parses cleanly.

Updated CHANGELOG with recent changes including improvements to pre-push tests, CI workflows, accessibility features, and bug fixes. Added details on new scripts for checking broken links and enhancing HTML report tables.
@vercel

vercel Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

@propcgamer20-png is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown

@yakew7 @ahmdkaml - new PR to review.

@yakew7
yakew7 merged commit bb5ea8e into yakew7:main Aug 14, 2026
18 of 19 checks passed
yakew7 added a commit that referenced this pull request Aug 14, 2026
Bump the snapshot to cover #256, #258, #259, #260, #261 - five PRs
merged since the last update (#238). Corrects ahmdkaml's merged-PR
count from 30 to 36 (the previous count undercounted due to gh pr
list's default 30-item page limit) and adds their #256/#258/#259
work. Credits evanjain-dot's ruff-linter PR (#261, closes #248) and
propcgamer20-png's report.py table-accessibility PR (#260, closes
#254), and adds propcgamer20-png to the Profiler - CLI & loaders area
row for touching faircode/report.py.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

faircode/report.py's HTML report tables have <th> header cells but no scope="col" or <caption>

2 participants