Fix proxy hints with flag activation - #358
Merged
Merged
Conversation
Contributor
|
@ahmdkaml is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@yakew7 - new PR touching a path you own, please review. |
yakew7
added a commit
that referenced
this pull request
Sep 2, 2026
…hot to #359 propcgamer20-png (#357), ahmdkaml (#358), and evanjain-dot (#359) each independently fixed issues #350 and #347 while this session was in progress. Syncs CONTRIBUTORS.md's PR/commit counts and per-contributor notes, and corrects the CHANGELOG's Unreleased entries to credit the actual authors instead of presenting the fixes as unattributed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where --proxy-hints-with silently had no effect unless --proxy-hints was also provided.
The proxy-hints path now activates when either --proxy-hints or --proxy-hints-with is supplied. This makes --proxy-hints-with usable on its own instead of requiring a redundant --proxy-hints flag.
Although the usual approach would be to flag this as an issue in the CLI, I think requiring users to type --proxy-hints --proxy-hints-with when --proxy-hints-with already expresses the intended behavior would be redundant.
Changes
Update the proxy-hints activation condition to accept either flag.
Preserve the existing behavior when --proxy-hints is used alone.
Verification
Existing test suite passes.
--proxy-hints-with now activates the proxy-hints functionality without requiring --proxy-hints.
Closes #347