fix: treat negative age sentinels as missing - #455
Merged
Conversation
be-student
requested review from
Shreyash0712,
ahmdkaml and
yakew7
as code owners
September 6, 2026 16:57
Contributor
|
@be-student is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@yakew7 @Shreyash0712 @ahmdkaml - new PR touching a path you own, please review. |
yakew7
added a commit
that referenced
this pull request
Sep 6, 2026
PR #455 and #456 both added a new test function at the exact same insertion point in tests/test_js_parity.py, and the merge that landed both spliced their bodies together wrong: test_python_js_profiler_parity_detects_dates_appended_after_numeric_ages lost its entire body (profile() call, node subprocess, comparison) after its setup lines, silently passing with zero assertions ever executed - while test_python_js_profiler_parity_rejects_negative_age_sentinels picked up an extra, contradictory assertion (`all(dim["name"] != "age" ...)`) that belongs to the other test and directly conflicts with its own next line, making it fail outright. Verified against each PR's original individual commit (f071a2b, 6ed1369) to reconstruct the correct, complete body for both functions rather than guessing. Both now pass, restoring real coverage for the date-sampling fix (#432) that this exact splice had been silently not testing at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Treats negative numeric and signed-string ages as missing in both profiler engines instead of assigning them to
75+. The shared spec and Python/JavaScript parity coverage now enforce the boundary.Type
Linked issue
Closes #431
Testing
python -m pytest tests/ -q(219 passed, 34 skipped)