Skip to content

Update submodule(voicevox_core 0.17.0 対応) - #315

Merged
actions-commit-pr-dekiru-kun[bot] merged 7 commits into
mainfrom
update-submodule-0.17.0
Aug 19, 2026
Merged

Update submodule(voicevox_core 0.17.0 対応)#315
actions-commit-pr-dekiru-kun[bot] merged 7 commits into
mainfrom
update-submodule-0.17.0

Conversation

@yamachu

@yamachu yamachu commented Aug 19, 2026

Copy link
Copy Markdown
Owner

This pull request updates the project to support voicevox_core version 0.17.0 and ONNX Runtime 1.23.2, along with several related changes to improve compatibility and align with upstream updates. The most important changes include updating dependency versions, adjusting native bindings, and making minor corrections to enums and documentation.

Dependency and Version Updates:

  • Upgraded voicevox_core to version 0.17.0 and ONNX Runtime to 1.23.2 throughout the project, including documentation, build scripts, and sample projects (README.md, examples/MAUI/README.md, examples/cli/README.md, .github/workflows/csharp_test.yml, examples/MAUI/MAUI.csproj, examples/MAUI/MainPageViewModel.cs, examples/UnitySample/Assets/SampleVoicevoxCoreSharpScript.cs, VERSIONS.md, binding/voicevox_core). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]

Native Binding and API Updates:

  • Updated native bindings in CoreUnsafe.g.cs to add new functions for retrieving the minimum and maximum supported ONNX Runtime minor versions, and switched to using the recommended filename functions for ONNX Runtime libraries. Also updated function documentation to reflect upstream changes and new version requirements. [1] [2] [3]
  • Changed the type of priority in VoicevoxUserDictWord from uint to byte to match upstream changes.

Enum and Result Code Adjustments:

  • Renamed RESULT_INVALID_MODEL_HEADER_ERROR to RESULT_INVALID_MODEL_FORMAT_ERROR in both the managed and native enums for consistency with upstream. Updated all relevant mappings. [1] [2] [3] [4]

Documentation and Sample Code Corrections:

  • Updated comments and documentation to reflect new validation logic and error/warning conditions, particularly for audio query, accent phrase, and mora validation functions. [1] [2] [3]

These changes ensure the project remains compatible with the latest voicevox_core and ONNX Runtime releases, and align the codebase with upstream API and documentation updates.This pull request updates the project to support voicevox_core version 0.17.0 and ONNX Runtime 1.23.2, along with several improvements and code cleanups. The most significant changes are version upgrades across the codebase, updates to native bindings for new ONNX Runtime APIs, and some refinements to error codes and documentation in the C# bindings.

Version Upgrades and Dependency Updates

  • Updated all references, scripts, and documentation to use voicevox_core version 0.17.0 and ONNX Runtime 1.23.2, replacing the previous 0.16.0/1.17.3 versions. This includes changes in sample projects, workflow scripts, and download instructions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]

C# Native Binding and API Improvements

  • Added new P/Invoke bindings in CoreUnsafe.g.cs for ONNX Runtime version queries: functions to get the minimum required and maximum supported minor versions, and updated the recommended filename APIs to match upstream changes.
  • Updated documentation comments for ONNX Runtime loading/initialization to clarify version compatibility and warning behavior. [1] [2]
  • Adjusted field types and enum values in native struct and enums to match upstream changes: changed VoicevoxUserDictWord.priority from uint to byte and renamed error codes from INVALID_MODEL_HEADER_ERROR to INVALID_MODEL_FORMAT_ERROR. [1] [2] [3] [4] [5]

Documentation and Sample Code Updates

  • Updated documentation and comments to reflect the new versions and clarify error/warning conditions in API usage, especially around accent phrase and mora validation. [1] [2] [3]

These changes keep the project in sync with the latest voicevox_core features and requirements, and improve clarity and correctness in the C# bindings and related documentation.

@yamachu
yamachu force-pushed the update-submodule-0.17.0 branch from ae07401 to 96f5644 Compare August 19, 2026 14:43
@yamachu yamachu added the breaking Breaking changes label Aug 19, 2026
@yamachu

yamachu commented Aug 19, 2026

Copy link
Copy Markdown
Owner Author

/mq

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

Testing: https://github.com/yamachu/VoicevoxCoreSharp/actions/runs/32267311161
You can view state by GitHub CLI below command:

  • gh run view --repo yamachu/VoicevoxCoreSharp 32267311161
  • gh run watch --repo yamachu/VoicevoxCoreSharp 32267311161

If you want to cancel the test, you can cancel it by GitHub CLI below command:

  • gh run cancel --repo yamachu/VoicevoxCoreSharp 32267311161

@actions-commit-pr-dekiru-kun
actions-commit-pr-dekiru-kun Bot merged commit fa53ddf into main Aug 19, 2026
14 checks passed
@actions-commit-pr-dekiru-kun
actions-commit-pr-dekiru-kun Bot deleted the update-submodule-0.17.0 branch August 19, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant