Update submodule(voicevox_core 0.17.0 対応) - #315
Merged
Conversation
yamachu
force-pushed
the
update-submodule-0.17.0
branch
from
August 19, 2026 14:43
ae07401 to
96f5644
Compare
Owner
Author
|
/mq |
Contributor
Contributor
|
Testing: https://github.com/yamachu/VoicevoxCoreSharp/actions/runs/32267311161
If you want to cancel the test, you can cancel it by GitHub CLI below command:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the project to support voicevox_core version 0.17.0 and ONNX Runtime 1.23.2, along with several related changes to improve compatibility and align with upstream updates. The most important changes include updating dependency versions, adjusting native bindings, and making minor corrections to enums and documentation.
Dependency and Version Updates:
0.17.0and ONNX Runtime to1.23.2throughout the project, including documentation, build scripts, and sample projects (README.md,examples/MAUI/README.md,examples/cli/README.md,.github/workflows/csharp_test.yml,examples/MAUI/MAUI.csproj,examples/MAUI/MainPageViewModel.cs,examples/UnitySample/Assets/SampleVoicevoxCoreSharpScript.cs,VERSIONS.md,binding/voicevox_core). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Native Binding and API Updates:
CoreUnsafe.g.csto add new functions for retrieving the minimum and maximum supported ONNX Runtime minor versions, and switched to using the recommended filename functions for ONNX Runtime libraries. Also updated function documentation to reflect upstream changes and new version requirements. [1] [2] [3]priorityinVoicevoxUserDictWordfromuinttobyteto match upstream changes.Enum and Result Code Adjustments:
RESULT_INVALID_MODEL_HEADER_ERRORtoRESULT_INVALID_MODEL_FORMAT_ERRORin both the managed and native enums for consistency with upstream. Updated all relevant mappings. [1] [2] [3] [4]Documentation and Sample Code Corrections:
These changes ensure the project remains compatible with the latest voicevox_core and ONNX Runtime releases, and align the codebase with upstream API and documentation updates.This pull request updates the project to support voicevox_core version 0.17.0 and ONNX Runtime 1.23.2, along with several improvements and code cleanups. The most significant changes are version upgrades across the codebase, updates to native bindings for new ONNX Runtime APIs, and some refinements to error codes and documentation in the C# bindings.
Version Upgrades and Dependency Updates
voicevox_coreversion 0.17.0 and ONNX Runtime 1.23.2, replacing the previous 0.16.0/1.17.3 versions. This includes changes in sample projects, workflow scripts, and download instructions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]C# Native Binding and API Improvements
CoreUnsafe.g.csfor ONNX Runtime version queries: functions to get the minimum required and maximum supported minor versions, and updated the recommended filename APIs to match upstream changes.VoicevoxUserDictWord.priorityfromuinttobyteand renamed error codes fromINVALID_MODEL_HEADER_ERRORtoINVALID_MODEL_FORMAT_ERROR. [1] [2] [3] [4] [5]Documentation and Sample Code Updates
These changes keep the project in sync with the latest voicevox_core features and requirements, and improve clarity and correctness in the C# bindings and related documentation.